Investigate test failures in maven deploy process

Need to investigate the pipeline failures (only the ones triggered at develop branch)

https://labs.etsi.org/rep/osl/code/org.etsi.osl.tmf.api/-/pipelines?scope=all&page=1

added critical typebug labels

assigned to @g.tziavas and @kyriakoulis

created branch 49-investigate-test-failures-in-maven-deploy-process to address this issue

When running only the package org.etsi.osl.services.api:

• ResourceOrderIntegrationTest

  • testResourceOrderCreate --> java.lang.AssertionError: Status expected:<200> but was:<500>

• AlarmManagementIntegrationTest

  • testAlarmCreateAndUpdateRoutes --> java.lang.NullPointerException: Cannot invoke "org.etsi.osl.tmf.am642.model.Alarm.getAckState()" because "alarm" is null

When running only the package org.etsi.osl.services.reposervices.scm633:

✓ All tests pass

When running only the package org.etsi.osl.services.service:

✓ All tests pass

When running all the tests together:

passed (✓)	failed (X)
271	44

Package: org.etsi.osl.services.api

ServiceCatalogIntegrationTest

Test Name	Error
testGST	org.opentest4j.AssertionFailedError: expected: 2 but was: 4
testVINNISBT	org.opentest4j.AssertionFailedError: expected: 2 but was: 4
testBundledSpec	org.opentest4j.AssertionFailedError: expected: 5 but was: 7
addCatalogAddCategory	org.opentest4j.AssertionFailedError: expected: 2 but was: 4
testCloneSpec	org.opentest4j.AssertionFailedError: expected: 1 but was: 3
_countDefaultProperties	org.opentest4j.AssertionFailedError: expected: 1 but was: 3
testSpecAttachment	org.opentest4j.AssertionFailedError: expected: 2 but was: 4
testExternhalSpecUpdate	org.opentest4j.AssertionFailedError: expected: 2 but was: 4
testSpecAttributesUpdate	org.opentest4j.AssertionFailedError: expected: 2 but was: 4
testSpecDelete	org.opentest4j.AssertionFailedError: expected: 1 but was: 3
testGSTUpdate	org.opentest4j.AssertionFailedError: expected: 1 but was: 3

All assertion errors have an offset of 2. Since when running the test on its own does not fail, I guess the DB instead of being initialised, is updated with inserting again the initial resources of the test.

Similar errors could be found in other test suites as well. These were fixed by adding @AutoConfigureTestDatabase.

After fixing these errors when running all the tests together we got:

passed (✓)	failed (X)
290	25

• ResourceOrderIntegrationTest

  • testResourceOrderCreate --> java.lang.AssertionError: Status expected:<200> but was:<500>

• package org.etsi.osl.services.service;

  • ServiceRepoServiceTest
    • All tests due to java errors.

@ktrantzas Since all remaining errors seem to be due to more intricate reasons, I suggest to create 2 different issues, one for ResourceOrderIntegrationTest and one for ServiceRepoServiceTest in order to further investigate them.

These commits are affecting the issue:

• 6bbb399d
• 4147a21b

mentioned in merge request !40 (merged)

mentioned in issue org.etsi.osl.main#33 (closed)

marked this issue as related to org.etsi.osl.main#33 (closed)

added statusunder review label

marked this issue as blocking #51 (closed)

mentioned in commit 53583e88

mentioned in commit 4ec8520c

mentioned in commit e84344f3

mentioned in commit 5f7f7808

mentioned in commit 8e204be8

mentioned in commit 128f5415

mentioned in commit 12b111ad

The TMF-api related errors were due to an image version.

Updating maven:3.9.5-ibm-semeru-17-focal to maven:3.9.9-ibm-semeru-17-focal resolves this issue.

Relates to org.etsi.osl.main#35 (closed)

marked this issue as related to org.etsi.osl.main#35 (closed)

added to epic osl&5 (closed)

removed statusunder review label

closed

mentioned in commit 1b110769

mentioned in commit 2240d16e

mentioned in commit b4aea404

mentioned in commit b4cfb12f

mentioned in commit 427dc1e8

mentioned in commit 7bbeab7f

mentioned in commit b18fffa7

mentioned in commit ef4f0e90

mentioned in commit 14aacb62