Commit 89d67951 authored by Martti Käärik's avatar Martti Käärik
Browse files

Constraints that cannot be evaluated are defect only on valid models in tests

parent 811dfb83
Loading
Loading
Loading
Loading
Loading
+6 −1
Changes for plugins/org.etsi.mts.tdl.tx.tests/src/org/etsi/mts/tdl/tx/tests/constraints/ConstraintSuiteTest.java: 6 added lines, 1 removed line.
Original line number Diff line number Diff line
@@ -194,8 +194,13 @@ public class ConstraintSuiteTest extends TDLtxAbstractTest {
					problems.add("unexpected " + e.getKey() + " x" + e.getValue());
				}
			}
			// A constraint that cannot be evaluated is a defect only on a valid model. On a fixture that
			// violates a constraint on purpose, other constraints may well have nothing to evaluate (an
			// unresolvable type, say): that is a consequence of the mistake the fixture expects.
			if (expectations.expected.isEmpty()) {
				for (String id : failed.keySet()) {
				problems.add(id + " could not be evaluated on this model: its OCL yields invalid, which also stops the constraints evaluated after it on this element");
					problems.add(id + " could not be evaluated on this valid model: its OCL yields invalid");
				}
			}
			if (!other.isEmpty()) {
				problems.add("issues that are not constraints (broken fixture?): " + other);