Fix test_mapper functions (27abe54d) · Commits · TFS / nsc

src/tests/test_mapper.py

+57 −14

Original line number	Diff line number	Diff line
		@@ -331,7 +331,11 @@ class TestMapper:
		"PLANNER_ENABLED": False
		}

		result = mapper(sample_ietf_intent)
		payload = {
		"intent": sample_ietf_intent
		}

		result = mapper(payload)

		assert result == ([sample_ietf_intent], None)

		@@ -348,7 +352,11 @@ class TestMapper:
		mock_planner_instance.planner.return_value = {"path": "node1->node2->node3"}
		mock_planner_class.return_value = mock_planner_instance

		result = mapper(sample_ietf_intent)
		payload = {
		"intent": sample_ietf_intent
		}

		result = mapper(payload)

		assert result == ([sample_ietf_intent], {"path": "node1->node2->node3"})
		mock_planner_instance.planner.assert_called_once_with(sample_ietf_intent, "ENERGY", is_update=False)
		@@ -363,7 +371,10 @@ class TestMapper:

		mock_realizer.return_value = sample_nrp_view

		result = mapper(sample_ietf_intent)
		payload = {
		"intent": sample_ietf_intent
		}
		result = mapper(payload)

		# Verify realizer was called to READ NRP view
		assert mock_realizer.call_args_list[0] == call(None, True, "READ")
		@@ -394,7 +405,11 @@ class TestMapper:

		mock_realizer.return_value = nrp_view

		result = mapper(sample_ietf_intent)
		payload = {
		"intent": sample_ietf_intent
		}

		result = mapper(payload)

		assert result == ([sample_ietf_intent], None)

		@@ -411,7 +426,11 @@ class TestMapper:

		mock_realizer.side_effect = [nrp_view, None] # First call returns empty, second for CREATE

		result = mapper(sample_ietf_intent)
		payload = {
		"intent": sample_ietf_intent
		}

		result = mapper(payload)

		# Verify CREATE was called
		create_call = [c for c in mock_realizer.call_args_list if len(c[0]) > 2 and c[0][2] == "CREATE"]
		@@ -433,7 +452,10 @@ class TestMapper:
		mock_planner_instance.planner.return_value = {"path": "optimized_path"}
		mock_planner_class.return_value = mock_planner_instance

		result = mapper(sample_ietf_intent)
		payload = {
		"intent": sample_ietf_intent
		}
		result = mapper(payload)

		# Planner should be called and return the result
		assert result == ([sample_ietf_intent],{"path": "optimized_path"})
		@@ -448,7 +470,10 @@ class TestMapper:

		mock_realizer.return_value = sample_nrp_view

		result = mapper(sample_ietf_intent)
		payload = {
		"intent": sample_ietf_intent
		}
		result = mapper(payload)

		# Verify UPDATE was called
		update_calls = [c for c in mock_realizer.call_args_list if len(c[0]) > 2 and c[0][2] == "UPDATE"]
		@@ -464,7 +489,10 @@ class TestMapper:

		mock_realizer.return_value = []

		mapper(sample_ietf_intent)
		payload = {
		"intent": sample_ietf_intent
		}
		mapper(payload)

		# Verify the function processed the intent
		assert mock_realizer.called
		@@ -480,7 +508,10 @@ class TestMapper:
		with patch('src.mapper.main.realizer') as mock_realizer:
		mock_realizer.return_value = sample_nrp_view

		mapper(sample_ietf_intent)
		payload = {
		"intent": sample_ietf_intent
		}
		mapper(payload)

		# Verify debug logging was called
		assert mock_logging.debug.called
		@@ -499,7 +530,10 @@ class TestMapperIntegration:
		with patch('src.mapper.main.realizer') as mock_realizer:
		mock_realizer.return_value = sample_nrp_view

		result = mapper(sample_ietf_intent)
		payload = {
		"intent": sample_ietf_intent
		}
		result = mapper(payload)

		# Verify the workflow sequence
		assert mock_realizer.call_count >= 1
		@@ -526,7 +560,10 @@ class TestMapperIntegration:
		mock_planner_instance.planner.return_value = expected_path
		mock_planner_class.return_value = mock_planner_instance

		result = mapper(sample_ietf_intent)
		payload = {
		"intent": sample_ietf_intent
		}
		result = mapper(payload)

		assert result == ([sample_ietf_intent],expected_path)
		mock_planner_instance.planner.assert_called_once()
		@@ -549,7 +586,10 @@ class TestMapperIntegration:

		# Should handle gracefully
		try:
		result = mapper(sample_ietf_intent)
		payload = {
		"intent": sample_ietf_intent
		}
		result = mapper(payload)
		except (KeyError, TypeError):
		# Expected to fail gracefully
		pass
		@@ -577,8 +617,11 @@ class TestMapperIntegration:
		}
		}

		payload = {
		"intent": invalid_intent
		}
		try:
		mapper(invalid_intent)
		mapper(payload)
		except (KeyError, TypeError):
		# Expected behavior
		pass