Feat/monitoring major functional updates

Feat/monitoring major functional updates

proto/monitoring.proto

@@ -19,24 +19,24 @@ import "context.proto";
 import "kpi_sample_types.proto";
 
 service MonitoringService {
-  rpc SetKpi                (KpiDescriptor      ) returns (KpiId               ) {}
-  rpc DeleteKpi             (KpiId              ) returns (context.Empty       ) {}
-  rpc GetKpiDescriptor      (KpiId              ) returns (KpiDescriptor       ) {}
-  rpc GetKpiDescriptorList  (context.Empty      ) returns (KpiDescriptorList   ) {}
-  rpc IncludeKpi            (Kpi                ) returns (context.Empty       ) {}
-  rpc MonitorKpi            (MonitorKpiRequest  ) returns (context.Empty       ) {}
-  rpc QueryKpiData          (KpiQuery           ) returns (KpiList             ) {}
-  rpc SetKpiSubscription    (SubsDescriptor     ) returns (stream KpiList      ) {}
-  rpc GetSubsDescriptor     (SubscriptionID     ) returns (SubsDescriptor      ) {}
-  rpc GetSubscriptions      (context.Empty      ) returns (SubsIDList          ) {}
-  rpc DeleteSubscription    (SubscriptionID     ) returns (context.Empty       ) {}
-  rpc SetKpiAlarm           (AlarmDescriptor    ) returns (AlarmID             ) {}
-  rpc GetAlarms             (context.Empty      ) returns (AlarmIDList         ) {}
-  rpc GetAlarmDescriptor    (AlarmID            ) returns (AlarmDescriptor     ) {}
-  rpc GetAlarmResponseStream(AlarmSubscription  ) returns (stream AlarmResponse) {}
-  rpc DeleteAlarm           (AlarmID            ) returns (context.Empty       ) {}
-  rpc GetStreamKpi          (KpiId              ) returns (stream Kpi          ) {}
-  rpc GetInstantKpi         (KpiId              ) returns (KpiList             ) {}
+  rpc SetKpi                (KpiDescriptor      ) returns (KpiId               ) {} // Stable not final
+  rpc DeleteKpi             (KpiId              ) returns (context.Empty       ) {} // Stable and final
+  rpc GetKpiDescriptor      (KpiId              ) returns (KpiDescriptor       ) {} // Stable and final
+  rpc GetKpiDescriptorList  (context.Empty      ) returns (KpiDescriptorList   ) {} // Stable and final
+  rpc IncludeKpi            (Kpi                ) returns (context.Empty       ) {} // Stable and final
+  rpc MonitorKpi            (MonitorKpiRequest  ) returns (context.Empty       ) {} // Stable and final
+  rpc QueryKpiData          (KpiQuery           ) returns (KpiList             ) {} // Not implemented
+  rpc SetKpiSubscription    (SubsDescriptor     ) returns (stream SubsResponse ) {} // Stable not final
+  rpc GetSubsDescriptor     (SubscriptionID     ) returns (SubsDescriptor      ) {} // Stable and final
+  rpc GetSubscriptions      (context.Empty      ) returns (SubsList            ) {} // Stable and final
+  rpc DeleteSubscription    (SubscriptionID     ) returns (context.Empty       ) {} // Stable and final
+  rpc SetKpiAlarm           (AlarmDescriptor    ) returns (AlarmID             ) {} // Stable not final
+  rpc GetAlarms             (context.Empty      ) returns (AlarmList           ) {} // Stable and final
+  rpc GetAlarmDescriptor    (AlarmID            ) returns (AlarmDescriptor     ) {} // Stable and final
+  rpc GetAlarmResponseStream(AlarmSubscription  ) returns (stream AlarmResponse) {} // Not Stable not final
+  rpc DeleteAlarm           (AlarmID            ) returns (context.Empty       ) {} // Stable and final
+  rpc GetStreamKpi          (KpiId              ) returns (stream Kpi          ) {} // Stable not final
+  rpc GetInstantKpi         (KpiId              ) returns (Kpi             ) {} // Stable not final
 }
 
 message KpiDescriptor {
@@ -58,7 +58,7 @@ message MonitorKpiRequest {
 }
 
 message KpiQuery {
-  repeated KpiId    kpi_id              = 1;
+  KpiId    kpi_id              = 1;
   float             monitoring_window_s = 2;
   float             sampling_rate_s     = 3;
   uint32            last_n_samples      = 4;  // used when you want something like "get the last N many samples
@@ -99,7 +99,7 @@ message KpiValue {
 
 
 message KpiList {
-  repeated Kpi kpi_list = 1;
+  repeated Kpi kpi = 1;
 }
 
 message KpiDescriptorList {
@@ -122,19 +122,19 @@ message SubscriptionID {
 
 message SubsResponse {
   SubscriptionID   subs_id  = 1;
-  repeated KpiList kpi_list = 2;
+  KpiList          kpi_list = 2;
 }
 
-message SubsIDList {
-  repeated SubscriptionID subs_list = 1;
+message SubsList {
+  repeated SubsDescriptor subs_descriptor = 1;
 }
 
 message AlarmDescriptor {
   AlarmID                     alarm_id              = 1;
   string                      alarm_description     = 2;
   string                      name                  = 3;
-  repeated KpiId              kpi_id                = 4;
-  repeated KpiValueRange      kpi_value_range       = 5;
+  KpiId                       kpi_id                = 4;
+  KpiValueRange               kpi_value_range       = 5;
   context.Timestamp           timestamp             = 6;
 }
 
@@ -143,7 +143,7 @@ message AlarmID{
 }
 
 message AlarmSubscription{
-  AlarmID alarmID                   = 1;
+  AlarmID alarm_id                  = 1;
   float   subscription_timeout_s    = 2;
   float   subscription_frequency_ms = 3;
 }
@@ -151,10 +151,9 @@ message AlarmSubscription{
 message AlarmResponse {
   AlarmID           alarm_id  = 1;
   string            text      = 2;
-  KpiValue          kpi_value = 3;
-  context.Timestamp timestamp = 4;
+  KpiList           kpi_list  = 3;
 }
 
-message AlarmIDList {
-    repeated AlarmID alarm_list = 1;
+message AlarmList {
+    repeated AlarmDescriptor alarm_descriptor = 1;
 }