Skip to content
Snippets Groups Projects
Commit fe7427b9 authored by Lluis Gifre Renom's avatar Lluis Gifre Renom
Browse files

Minor changes to remove code linting warnings

parent 39474919
No related branches found
No related tags found
1 merge request!54Release 2.0.0
...@@ -16,12 +16,12 @@ from context.service.rest_server.resources.Context import Context ...@@ -16,12 +16,12 @@ from context.service.rest_server.resources.Context import Context
terminate = threading.Event() terminate = threading.Event()
logger = None logger = None
def signal_handler(signal, frame): def signal_handler(signal_, frame):
logger.warning('Terminate signal received') logger.warning('Terminate signal received')
terminate.set() terminate.set()
def main(): def main():
global logger global logger # pylint: disable=global-statement
grpc_service_port = get_setting('CONTEXTSERVICE_SERVICE_PORT_GRPC', default=GRPC_SERVICE_PORT ) grpc_service_port = get_setting('CONTEXTSERVICE_SERVICE_PORT_GRPC', default=GRPC_SERVICE_PORT )
max_workers = get_setting('MAX_WORKERS', default=GRPC_MAX_WORKERS ) max_workers = get_setting('MAX_WORKERS', default=GRPC_MAX_WORKERS )
......
...@@ -29,9 +29,9 @@ class ContextService: ...@@ -29,9 +29,9 @@ class ContextService:
self.server = None self.server = None
def start(self): def start(self):
self.endpoint = '{}:{}'.format(self.address, self.port) self.endpoint = '{:s}:{:s}'.format(self.address, self.port)
LOGGER.debug('Starting Service (tentative endpoint: {}, max_workers: {})...'.format( LOGGER.debug('Starting Service (tentative endpoint: {:s}, max_workers: {:s})...'.format(
self.endpoint, self.max_workers)) str(self.endpoint), str(self.max_workers)))
self.pool = futures.ThreadPoolExecutor(max_workers=self.max_workers) self.pool = futures.ThreadPoolExecutor(max_workers=self.max_workers)
self.server = grpc.server(self.pool) # , interceptors=(tracer_interceptor,)) self.server = grpc.server(self.pool) # , interceptors=(tracer_interceptor,))
...@@ -44,15 +44,15 @@ class ContextService: ...@@ -44,15 +44,15 @@ class ContextService:
add_HealthServicer_to_server(self.health_servicer, self.server) add_HealthServicer_to_server(self.health_servicer, self.server)
port = self.server.add_insecure_port(self.endpoint) port = self.server.add_insecure_port(self.endpoint)
self.endpoint = '{}:{}'.format(self.address, port) self.endpoint = '{:s}:{:s}'.format(str(self.address), str(port))
LOGGER.info('Listening on {}...'.format(self.endpoint)) LOGGER.info('Listening on {:s}...'.format(str(self.endpoint)))
self.server.start() self.server.start()
self.health_servicer.set(OVERALL_HEALTH, HealthCheckResponse.SERVING) # pylint: disable=maybe-no-member self.health_servicer.set(OVERALL_HEALTH, HealthCheckResponse.SERVING) # pylint: disable=maybe-no-member
LOGGER.debug('Service started') LOGGER.debug('Service started')
def stop(self): def stop(self):
LOGGER.debug('Stopping service (grace period {} seconds)...'.format(self.grace_period)) LOGGER.debug('Stopping service (grace period {:s} seconds)...'.format(str(self.grace_period)))
self.health_servicer.enter_graceful_shutdown() self.health_servicer.enter_graceful_shutdown()
self.server.stop(self.grace_period) self.server.stop(self.grace_period)
LOGGER.debug('Service stopped') LOGGER.debug('Service stopped')
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment