Commit b17cb7f8 authored by Waleed Akbar's avatar Waleed Akbar
Browse files

some changes required to do the tests.

parent c4a662d3

src/kpi_manager/service/database/Kpi_DB.py

+1 −1
Original line number Diff line number Diff line
@@ -31,7 +31,7 @@ class Kpi_DB: 
            return False

        self.db_name = DB_NAME

        # self.drop_database(self.db_engine)          # added to test

        self.create_database(self.db_engine)         # to add database

        # self.create_database(self.db_engine)         # to add database

        self.Session = sessionmaker(bind=self.db_engine)



    @staticmethod

src/kpi_manager/tests/test_kpi_composer.py

+4 −4
Original line number Diff line number Diff line
@@ -22,10 +22,10 @@ def test_compose_kpi(): 
    LOGGER.info(' >>> test_compose_kpi START <<< ')

    KpiValueComposer.compose_kpi()



def test_request_kpi_descriptor_from_db():

    LOGGER.info(' >>> test_request_kpi_descriptor_from_db START <<< ')

    KpiValueComposer.request_kpi_descriptor_from_db()

# def test_request_kpi_descriptor_from_db():

#     LOGGER.info(' >>> test_request_kpi_descriptor_from_db START <<< ')

#     KpiValueComposer.request_kpi_descriptor_from_db()



# def test_delete_kpi_by_id():

#     LOGGER.info(' >>> test_request_kpi_descriptor_from_db START <<< ')

#     LOGGER.info(' >>> test_test_delete_kpi_by_id START <<< ')

#     KpiValueComposer.delete_kpi_by_id()
 
 No newline at end of file

src/kpi_manager/tests/test_kpi_manager.py

+21 −21
Original line number Diff line number Diff line
@@ -213,7 +213,7 @@ def kpi_manager_client(kpi_manager_service : KpiManagerService): # pylint: disab 
# ---------- 2nd Iteration Tests -----------------

def test_SetKpiDescriptor(kpi_manager_client):

    LOGGER.info(" >>> test_SetKpiDescriptor: START <<< ")

    with open("kpi_manager/service/KPI_configs.json", 'r') as file:

    with open("kpi_manager/tests/KPI_configs.json", 'r') as file:

        data = json.load(file)

        _descriptors = data.get('KPIs', [])

    for _descritor_name in _descriptors:
@@ -221,26 +221,26 @@ def test_SetKpiDescriptor(kpi_manager_client): 
        LOGGER.info("Response gRPC message object: {:}".format(response))

    assert isinstance(response, KpiId)



def test_GetKpiDescriptor(kpi_manager_client):

    LOGGER.info(" >>> test_GetKpiDescriptor: START <<< ")

    response = kpi_manager_client.GetKpiDescriptor(create_kpi_id_request())

    LOGGER.info("Response gRPC message object: {:}".format(response))

    assert isinstance(response, KpiDescriptor)



def test_DeleteKpiDescriptor(kpi_manager_client):

    LOGGER.info(" >>> test_DeleteKpiDescriptor: START <<< ")

    response = kpi_manager_client.SetKpiDescriptor(create_kpi_descriptor_request())

    del_response = kpi_manager_client.DeleteKpiDescriptor(response)

    kpi_manager_client.GetKpiDescriptor(response)

    LOGGER.info("Response of delete method gRPC message object: {:}".format(del_response))

    assert isinstance(del_response, Empty)



def test_SelectKpiDescriptor(kpi_manager_client):

    LOGGER.info(" >>> test_SelectKpiDescriptor: START <<< ")

    kpi_manager_client.SetKpiDescriptor(create_kpi_descriptor_request_a())

    response = kpi_manager_client.SelectKpiDescriptor(create_kpi_filter_request_a())

    LOGGER.info("Response gRPC message object: {:}".format(response))

    assert isinstance(response, KpiDescriptorList)

# def test_GetKpiDescriptor(kpi_manager_client):

#     LOGGER.info(" >>> test_GetKpiDescriptor: START <<< ")

#     response = kpi_manager_client.GetKpiDescriptor(create_kpi_id_request())

#     LOGGER.info("Response gRPC message object: {:}".format(response))

#     assert isinstance(response, KpiDescriptor)



# def test_DeleteKpiDescriptor(kpi_manager_client):

#     LOGGER.info(" >>> test_DeleteKpiDescriptor: START <<< ")

#     response = kpi_manager_client.SetKpiDescriptor(create_kpi_descriptor_request())

#     del_response = kpi_manager_client.DeleteKpiDescriptor(response)

#     kpi_manager_client.GetKpiDescriptor(response)

#     LOGGER.info("Response of delete method gRPC message object: {:}".format(del_response))

#     assert isinstance(del_response, Empty)



# def test_SelectKpiDescriptor(kpi_manager_client):

#     LOGGER.info(" >>> test_SelectKpiDescriptor: START <<< ")

#     kpi_manager_client.SetKpiDescriptor(create_kpi_descriptor_request_a())

#     response = kpi_manager_client.SelectKpiDescriptor(create_kpi_filter_request_a())

#     LOGGER.info("Response gRPC message object: {:}".format(response))

#     assert isinstance(response, KpiDescriptorList)



# ------------- INITIAL TESTs ----------------

# Test case that makes use of client fixture to test server's CreateKpi method

src/telemetry/backend/service/TelemetryBackendService.py

+1 −1
Original line number Diff line number Diff line
@@ -152,7 +152,7 @@ class TelemetryBackendService: 
                if topic not in topic_metadata.topics:

                    # If the topic does not exist, create a new topic

                    print(f"Topic '{topic}' does not exist. Creating...")

                    LOGGER.info("Topic {:} does not exist. Creating...")

                    LOGGER.warning("Topic {:} does not exist. Creating...".format(topic))

                    new_topic = NewTopic(topic, num_partitions=1, replication_factor=1)

                    ADMIN_KAFKA_CLIENT.create_topics([new_topic])

            except KafkaException as e: