Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
controller
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
TFS
controller
Commits
7f93ab1f
Commit
7f93ab1f
authored
3 years ago
by
Javi Moreno
Browse files
Options
Downloads
Patches
Plain Diff
Adding more tests
parent
6dc53cb1
No related branches found
No related tags found
1 merge request
!54
Release 2.0.0
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
src/monitoring/service/monitoring_server.py
+13
-1
13 additions, 1 deletion
src/monitoring/service/monitoring_server.py
src/monitoring/tests/test_monitoring.py
+13
-2
13 additions, 2 deletions
src/monitoring/tests/test_monitoring.py
with
26 additions
and
3 deletions
src/monitoring/service/monitoring_server.py
+
13
−
1
View file @
7f93ab1f
...
...
@@ -66,7 +66,6 @@ class MonitoringServiceServicerImpl(monitoring_pb2_grpc.MonitoringServiceService
kpi
=
get_Kpi
(
request
.
kpi_id
)
monitor_device_request
.
kpi
.
kpi_id
.
kpi_id
.
uuid
=
kpi
.
kpi_id
.
kpi_id
.
uuid
monitor_device_request
.
connexion_time_s
=
request
.
connexion_time_s
monitor_device_request
.
sample_rate_ms
=
request
.
sample_rate_ms
...
...
@@ -81,12 +80,25 @@ class MonitoringServiceServicerImpl(monitoring_pb2_grpc.MonitoringServiceService
# Some code device to perform its actions
LOGGER
.
info
(
'
MonitorDeviceKpi
'
)
# Notify device about monitoring
return
context_pb2
.
Empty
()
# rpc IncludeKpi(IncludeKpiRequest) returns(context.Empty) {}
def
IncludeKpi
(
self
,
request
:
monitoring_pb2
.
IncludeKpiRequest
,
context
)
->
context_pb2
.
Empty
:
LOGGER
.
info
(
'
IncludeKpi
'
)
kpi
=
get_Kpi
(
request
.
kpi_id
)
time_stamp
=
request
.
time_stamp
kpi_value
=
request
.
kpi_value
# Build the structure to be included as point in the influxDB
# Send the Kpi point to the influxDB
return
context_pb2
.
Empty
()
...
...
This diff is collapsed.
Click to expand it.
src/monitoring/tests/test_monitoring.py
+
13
−
2
View file @
7f93ab1f
...
...
@@ -94,6 +94,17 @@ def monitor_device_kpi_request():
return
monitor_device_kpi_request
@pytest.fixture
(
scope
=
'
session
'
)
def
include_kpi_request
():
LOGGER
.
warning
(
'
test_include_kpi begin
'
)
include_kpi_request
=
monitoring_pb2
.
IncludeKpiRequest
()
include_kpi_request
.
kpi_id
.
kpi_id
.
uuid
=
'
KPIID0000
'
include_kpi_request
.
time_stamp
=
"
2021-10-12T13:14:42Z
"
include_kpi_request
.
kpi_value
.
intVal
=
500
return
include_kpi_request
###########################
# Tests Implementation
###########################
...
...
@@ -121,10 +132,10 @@ def test_monitor_device_kpi(monitoring_client,monitor_device_kpi_request):
assert
isinstance
(
response
,
context_pb2
.
Empty
)
# Test case that makes use of client fixture to test server's IncludeKpi method
def
test_include_kpi
(
monitoring_client
,
kpi_request
):
def
test_include_kpi
(
monitoring_client
,
include_
kpi_request
):
# make call to server
LOGGER
.
warning
(
'
test_include_kpi requesting
'
)
response
=
monitoring_client
.
IncludeKpi
(
kpi_request
)
response
=
monitoring_client
.
IncludeKpi
(
include_
kpi_request
)
LOGGER
.
debug
(
str
(
response
))
assert
isinstance
(
response
,
context_pb2
.
Empty
)
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment