Fixing the conditional that triggers response.

src/opticalattackdetector/service/OpticalAttackDetectorServiceServicerImpl.py

@@ -221,7 +221,7 @@ class OpticalAttackDetectorServiceServicerImpl(OpticalAttackDetectorServiceServi
             monitoring_client.IncludeKpi(kpi)
 
         # if -1 in response.cluster_indices:  # attack detected
-        if kpi.kpi_value.int32Val == -1:
+        if kpi.kpi_value.int32Val == 1:
             attack = AttackDescription()
             attack.cs_id.uuid = request.service_id.service_uuid.uuid
             with HISTOGRAM_DURATION.labels(step="mitigation", **METRIC_LABELS).time():

src/opticalattackdetector/tests/test_unitary.py

@@ -63,8 +63,6 @@ def test_detect_attack(
         "opticalattackdetector.service.OpticalAttackDetectorServiceServicerImpl.monitoring_client.IncludeKpi",
     ) as monitoring, patch(
         "opticalattackdetector.service.OpticalAttackDetectorServiceServicerImpl.dbscanserving_client.Detect",
-        # TODO: return dumb object with "cluster_indices" attribute
-        # idea: create new response object
         return_value=message,
     ) as dbscanserving:
         for _ in range(10):