Skip to content
Snippets Groups Projects

added saref:FeatureOfInterest and saref:measurementMadeBy

Merged Maria Poveda requested to merge issue-40-Feature-of-interest into master

Changes implemented according to ETSI_TS_103_410-6 (SAREF4AGRI): From the development of the SAREF4AGRI ontology it has been observed the need for including the saref:FeatureOfInterest concept. Due to the general nature of such concept and its potential need in other extensions, for example SAREF4CITY, such concept is assumed to be included in SAREF 3.0 ontology. In the same line, the property saref:measurementMadeBy is proposed to be included into SAREF as inverse of saref:makesMeasurement to complete such model. Closes #40 (closed).

Edited by Raul Garcia-Castro

Merge request reports

Checking pipeline status.

Merged by Raul Garcia-CastroRaul Garcia-Castro 5 years ago (Nov 8, 2019 11:55am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • 77c41bb2 - Fixed the description of FeatureOfInterest.

    Compare with previous version

    By garciacastro on 2019-11-07T09:57:39 (imported from GitLab project)

  • Some properties and restrictions are missing. I'm updating them.

    By garciacastro on 2019-11-07T09:58:55 (imported from GitLab project)

  • added 1 commit

    • 85aa5b50 - Added two properties, plus a couple of minor fixes.

    Compare with previous version

    By garciacastro on 2019-11-07T10:07:35 (imported from GitLab project)

  • added 1 commit

    • d8b256df - Added the rest of properties and restrictions, and fixed the definition of property.

    Compare with previous version

    By garciacastro on 2019-11-07T10:17:57 (imported from GitLab project)

  • Added the declaration of the properties mentioned in the description as well as that of their inverse ones: hasFeatureOfInterest and isPropertyOf. Added the relevant restrictions in Measurement and Property. Made some minor fixes.

    By garciacastro on 2019-11-07T10:20:19 (imported from GitLab project)

  • Now I think that it is OK. @lefranois, can you check?

    By garciacastro on 2019-11-07T10:22:00 (imported from GitLab project)

  • Raul Garcia-Castro changed the description

    changed the description

    By garciacastro on 2019-11-07T10:52:22 (imported from GitLab project)

  • added 1 commit

    Compare with previous version

    By garciacastro on 2019-11-07T14:44:49 (imported from GitLab project)

  • saref:hasFeatureOfInterest

    The naming of the hasFeatureOfInterest property is historically too Measurement centric (or Observation-centric in the old SSN ontology) In the context of SAREF, wouldn't it make sense to rename this property to something like saref:isMeasurementOf?

    saref:isFeatureOfInterestOf

    Same comment: suggestion: saref:hasMeasurement

    saref:hasProperty:

    A relationship between an entity and a property of that entity -> replace entity by feature of interest?

    saref:isPropertyOf:

    Replace entity by feature of interest?

    saref:FeatureOfInterest

    A feature of interest represents any real world entity from which a property is measured. is measured -> can be measured or actuated on?

    The rest is all fine to me

    By lefranois on 2019-11-08T09:47:06 (imported from GitLab project)

  • Regarding the use of "entity" in the descriptions, I used it because for users it sounded more understandable for users. But since in the description of feature it already says that it is an entity, there is no problem in updating these descriptions (and others where it appears).

    Yes, saref:isMeasurementOf sounds better.

    Regarding saref:hasMeasurement, I'm not sure. With that name it seems like the measurements are an intrinsic part of the feature itself. What do you think about saref:isMeasuredBy?

    By garciacastro on 2019-11-08T10:47:26 (imported from GitLab project)

  • We already have saref:isMeasuredByDevice between property and device.

    If not saref:hasMeasurement, we need to find better and less confusing than saref:isMeasuredBy.

    No better, simple idea for the moment though.

    By lefranois on 2019-11-08T10:54:57 (imported from GitLab project)

  • It is true, I just didn't notice that one.

    Then, let's keep saref:hasMeasurement. I cannot come up with something better.

    By garciacastro on 2019-11-08T11:16:56 (imported from GitLab project)

  • added 1 commit

    • 69725981 - Renamed hasFeatureOfInterest as isMeasurementOf and isFeatureOfInterestOf as hasMeasurement.

    Compare with previous version

    By garciacastro on 2019-11-08T11:52:55 (imported from GitLab project)

  • The requested changes have been implemented. I merge them.

    By garciacastro on 2019-11-08T11:54:54 (imported from GitLab project)

  • mentioned in commit 8c98be5e

    By garciacastro on 2019-11-08T11:55:04 (imported from GitLab project)

  • merged

    By garciacastro on 2019-11-08T11:55:05 (imported from GitLab project)

Please register or sign in to reply