Skip to content
Snippets Groups Projects

NSLCM Statuses are now being offered as an array of Json Nodes

This MR updates the tmf.api to allow for the correct listing of all NSLCM statuses. To this end, we updated the process of adding a new NSLCM status to the list of all status. Before, we were working with string arraylists, which resulted in the incorrect encoding of the JSON NSLCM statuses payloads. Now, we are using the appropriate JSON-appropriate artifacts to manipulate the list of NSLCM statuses and append new statuses. This MR thus fixes the issue of the NSLCM statuses being showned as strings, as it is proven by the image below.

Screenshot_2024-09-07_at_21.34.39

Additionally, the updates were tested with various tests. These can be performed by executing the following command:

docker run -it --rm \
  -v "/home/ubuntu/.m2":/root/.m2 \
  -v "$(pwd)":/opt/maven \
  -w /opt/maven \
  maven:3.9.5-ibm-semeru-17-focal \
  mvn clean verify \
  -Dtest="ServiceRepoServiceTest#testUpdateNSLCMCharacteristicMethodWhenNSLCMValueToUpdateIsNull,ServiceRepoServiceTest#testUpdateNSLCMCharacteristicMethodWhenNSLCMValueToUpdateIsNotNullAndNSLCMDoesntAlreadyExist,ServiceRepoServiceTest#testUpdateNSLCMCharacteristicMethodWhenNSLCMValueToUpdateIsNotNullAndNSLCMAlreadyExists"

Closes #45 (closed)

Edited by direito

Merge request reports

Pipeline #8178 failed

Pipeline failed for 18f6798d on hotfix/45-nslcm-statuses-are-presented-as-strings-rather-than-jsons

Merged by trantzastrantzas 6 months ago (Sep 19, 2024 10:34am UTC)

Loading

Pipeline #9574 canceled

Pipeline canceled for eada418f on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading