Tmf 674 feature
This MR contains commits that enhance Geographic site Management api capabilities in order to support org.etsi.osl.tmf.web#17
Merge request reports
Activity
requested review from @ktrantzas and @g.tziavas
assigned to @papadopoulo1
requested review from @tranoris
41 55 } 42 56 } 43 57 44 @PreAuthorize("hasAnyAuthority('ROLE_USER')" ) 58 @PreAuthorize("hasAnyAuthority('ROLE_USER', 'ROLE_ADMIN')") changed this line in version 2 of the diff
Thanks @g.tziavas didn't know that. Fixed it!
66 67 log.debug("principal= " + principal.toString()); 68 69 Individual ind = individualRepoService.findByUsername(principal.getName()); 70 71 GeographicSite gs= geographicSiteManagementService.findGeographicSiteByRelatedPartyId(ind.getId()); 72 if (gs==null) { 73 gs =new GeographicSite(); 74 GeographicSubAddressValue geographicSubAddressValue=new GeographicSubAddressValue(); 75 GeographicAddressValue geographicAddressValue=new GeographicAddressValue(); 76 geographicAddressValue.setGeographicSubAddress(geographicSubAddressValue); 77 PlaceRefOrValue placeRefOrValue=new PlaceRefOrValue(geographicAddressValue); 78 List<PlaceRefOrValue> placeRefOrValues=new ArrayList<>(); 79 placeRefOrValues.add(placeRefOrValue); 80 gs.setPlace(placeRefOrValues); 81 } changed this line in version 2 of the diff
@g.tziavas the initial commit was created in order to just pass the "myuser" id and use this to fetch the geographic site related to this individual. After a quick feedback from @ktrantzas realised that this is a "dirty" solution and i changed it to pass directly the id we need in order to fetch the appropriate geographic site info
Closing this MR, as it was decided to integrate this feature after Release 2024Q2. We will review it after the release.
Also, this MR is unrelated to an issue within the respective project.
Edited by trantzas
