Tmf 674 feature

requested review from @ktrantzas

assigned to @papadopoulo1

One thing to take note is that the PlaceRefOrValue that describes the place does not have attribute GeographicAddress but instead a reference again. I suppose that maybe the open api yaml of the tmf 674 version 5 which the code generator used is incomplete or contains errors because in the sample json request of swagger it seems like geographic address is part of the place attribute.

Hey Labro, as you said the example contains GeographicAddress + the TMF628 specification pdf clearly includes it in the "place" property of GeographicAdress.

I propose to manually add the already defined "GeographicAdd‎ressValue" class to the class "PlaceRefOfValue".

added 1 commit

• 7a02a0cc - refactor: GeographicAddress part of the place

Compare with previous version

added 1 commit

• e02c3856 - fixing entity relationships

Compare with previous version

"The source branch is 1 commit behind the target branch · 7 commits and 1 merge commit will be added to develop."

Before merging through gitlab, do a rebase to your branch to have both branches aligned, and solve any possible conflicts.

mentioned in merge request org.etsi.osl.tmf.api!24 (merged)

requested review from @g.tziavas

added 3 commits

• f7c7cb8e - 1 commit from branch develop
• bb4bc0ae - Merge branch 'develop' into tmf-674-feature
• bc173ac0 - Change the entity names to be shorter + add description

Compare with previous version

resolved all threads

Hello @g.tziavas , thanks for the comments, i resolved the issues that you mentioned!

resolved all threads

approved this merge request

mentioned in commit 2afba05a

merged