Remove oauth client secret values (!63) · Merge requests · OSL / code / org.etsi.osl.main · GitLab

These values despite the name don't actually configure client secrets for use in openslice but instead the client secret displayed in the API documentation. So at best they are not useful and at worst a terrible footgun to leak client secrets.

Closes #55 (closed)

kubernetes/helm/openslice/templates/mcp-server.yaml

+0 −1

Changes for kubernetes/helm/openslice/templates/mcp-server.yaml: 0 added lines, 1 removed line.
Original line number	Diff line number	Diff line
		@@ -41,7 +41,6 @@ spec:
		"springdoc.oAuthFlow.authorizationUrl": "{{ .Values.rooturl }}/auth/realms/openslice/protocol/openid-connect/auth",
		"springdoc.oAuthFlow.tokenUrl": "{{ .Values.rooturl }}/auth/realms/openslice/protocol/openid-connect/token",
		"springdoc.oauth.client-id": "osapiWebClientId",
		"springdoc.oauth.clientsecret": "{{ .Values.mcpserver.springdoc.clientSecret }}",
		"spring.activemq.brokerUrl": "tcp://{{ include "openslice.fullname" . }}-artemis:61616?jms.watchTopicAdvisories=false",
		"logging.level.org.springframework": "{{ .Values.mcpserver.spring.logLevel \| default "INFO" }}"
		}

kubernetes/helm/openslice/templates/oasapi.yaml

+0 −1

Changes for kubernetes/helm/openslice/templates/oasapi.yaml: 0 added lines, 1 removed line.
Original line number	Diff line number	Diff line
		@@ -51,7 +51,6 @@ spec:
		"springdoc.oAuthFlow.authorizationUrl": "{{ .Values.rooturl }}/auth/realms/openslice/protocol/openid-connect/auth",
		"springdoc.oAuthFlow.tokenUrl": "{{ .Values.rooturl }}/auth/realms/openslice/protocol/openid-connect/token",
		"springdoc.oauth.client-id": "osapiWebClientId",
		"springdoc.oauth.clientsecret" : "{{ .Values.spring.oauthClientSecret }}",
		"spring.activemq.brokerUrl": "tcp://{{ include "openslice.fullname" . }}-artemis:61616?jms.watchTopicAdvisories=false",
		"logging.level.org.springframework" : "{{ .Values.oasapi.spring.logLevel \| default "INFO" }}",
		"server.forward-headers-strategy":"FRAMEWORK"

kubernetes/helm/openslice/templates/osportalapi.yaml

+0 −1

Changes for kubernetes/helm/openslice/templates/osportalapi.yaml: 0 added lines, 1 removed line.
Original line number	Diff line number	Diff line
		@@ -52,7 +52,6 @@ spec:
		"springdoc.oAuthFlow.authorizationUrl": "{{ .Values.rooturl }}/auth/realms/openslice/protocol/openid-connect/auth",
		"springdoc.oAuthFlow.tokenUrl": "{{ .Values.rooturl }}/auth/realms/openslice/protocol/openid-connect/token",
		"springdoc.oauth.client-id": "osapiWebClientId",
		"springdoc.oauth.clientsecret" : "{{ .Values.spring.oauthClientSecret }}",
		"spring.activemq.brokerUrl": "tcp://{{ include "openslice.fullname" . }}-artemis:61616?jms.watchTopicAdvisories=false",
		"logging.level.org.springframework" : "{{ .Values.portalapi.spring.logLevel \| default "INFO" }}",
		"logging.level.org.etsi.osl.portal.api": "{{ .Values.portalapi.logLevel \| default "INFO" }}",

kubernetes/helm/openslice/templates/osscapi.yaml

+0 −1

Changes for kubernetes/helm/openslice/templates/osscapi.yaml: 0 added lines, 1 removed line.
Original line number	Diff line number	Diff line
		@@ -52,7 +52,6 @@ spec:
		"springdoc.oAuthFlow.authorizationUrl":"{{ .Values.rooturl }}/auth/realms/openslice/protocol/openid-connect/auth",
		"springdoc.oAuthFlow.tokenUrl":"{{ .Values.rooturl }}/auth/realms/openslice/protocol/openid-connect/token",
		"springdoc.oauth.client-id": "osapiWebClientId",
		"springdoc.oauth.clientsecret" : "{{ .Values.spring.oauthClientSecret }}",
		"spring.activemq.brokerUrl": "tcp://{{ include "openslice.fullname" . }}-artemis:61616?jms.watchTopicAdvisories=false",
		"logging.level.org.springframework": "{{ .Values.osscapi.spring.logLevel \| default "INFO" }}",
		"kroki.serverurl":"{{ .Values.rooturl }}/kroki",

kubernetes/helm/openslice/values.yaml

+0 −5

Changes for kubernetes/helm/openslice/values.yaml: 0 added lines, 5 removed lines.
Original line number	Diff line number	Diff line
		@@ -119,9 +119,6 @@ oscreds:
		username: metricouser
		password: "12345"

		spring:
		oauthClientSecret: secret

		mysql:
		storage: 10Gi

		@@ -165,8 +162,6 @@ osscapi:

		mcpserver:
		enabled: true
		springdoc:
		clientSecret: secret
		spring:
		logLevel: INFO