Commit fed8abaa authored Apr 27, 2026 by Afonso Castanheta

Refactor user certificate validation error responses to use 404 Not Found for...

Refactor user certificate validation error responses to use 404 Not Found for non-existent Network App ID

parent ae7c1c42

services/TS29222_CAPIF_API_Invoker_Management_API/api_invoker_management/core/validate_user.py

+2 −2

Original line number	Diff line number	Diff line
		@@ -6,7 +6,7 @@ from ..encoder import CustomJSONEncoder
		from ..models.problem_details import ProblemDetails
		from ..util import serialize_clean_camel_case
		from .resources import Resource
		from .responses import forbidden_error, internal_server_error, unauthorized_error
		from .responses import forbidden_error, internal_server_error, not_found_error, unauthorized_error


		class ControlAccess(Resource):
		@@ -20,7 +20,7 @@ class ControlAccess(Resource):
		cert_entry = cert_col.find_one(my_query)

		if cert_entry is None:
		return unauthorized_error(detail="Please provide an existing Network App ID", cause="Certificate not found for invoker")
		return not_found_error(detail="Please provide an existing Network App ID", cause="Network App ID does not exist")

		if cert_entry["cert_signature"] != cert_signature:
		return forbidden_error(detail="User not authorized", cause="You are not the owner of this resource")

tests/features/CAPIF Api Invoker Management/capif_api_invoker_managenet.robot

+8 −8

Original line number	Diff line number	Diff line
		@@ -97,11 +97,11 @@ Update Not Onboarded Network App
		... username=${INVOKER_USERNAME}

		# Check Results
		Check Response Variable Type And Values ${resp} 401 ProblemDetails
		... status=401
		... title=Unauthorized
		Check Response Variable Type And Values ${resp} 404 ProblemDetails
		... status=404
		... title=Not Found
		... detail=Please provide an existing Network App ID
		... cause=Certificate not found for invoker
		... cause=Network App ID does not exist

		Offboard Network App
		[Tags] capif_api_invoker_management-5
		@@ -131,11 +131,11 @@ Offboard Not Previously Onboarded Network App
		... username=${INVOKER_USERNAME}

		# Check Results
		Check Response Variable Type And Values ${resp} 401 ProblemDetails
		... status=401
		... title=Unauthorized
		Check Response Variable Type And Values ${resp} 404 ProblemDetails
		... status=404
		... title=Not Found
		... detail=Please provide an existing Network App ID
		... cause=Certificate not found for invoker
		... cause=Network App ID does not exist

		Update Onboarded Network App Certificate
		[Tags] capif_api_invoker_management-7