Commit 886bbe16 authored by Matthias Simon's avatar Matthias Simon
Browse files

Add Word document review rules to the ETSI review skill.

Tracked changes on, author AI Reviewer, dark green; spelling and
editorial fixes as tracked edits, other issues as comments.

Co-authored-by: default avatarCursor <cursoragent@cursor.com>
parent b689dc2a
Loading
Loading
Loading
Loading
Loading
+31 −3
Changes for .agents/skills/reviewing-etsi-standards/SKILL.md: 31 added lines, 3 removed lines.
Original line number Diff line number Diff line
---
name: reviewing-etsi-standards
description: Reviews ETSI standards, draft clauses and change requests against the ETSI guide "Writing World Class Standards" and the ETSI Drafting Rules. Checks that every requirement is necessary, unambiguous, complete, precise, consistent and testable, and finds ambiguous wording, misused or undefined technical terms, and semantic gaps. Handles long documents by delegating the term inventory, section reviews, cross-section checks, verification and report writing to subagents. Use when the user asks to review, check, proofread or assess an ETSI deliverable (ES, EN, TS, TR, EG, GS), a TTCN-3 standard clause, a draft in src/, or a change request.
description: Reviews ETSI standards, draft clauses and change requests against the ETSI guide "Writing World Class Standards" and the ETSI Drafting Rules. Checks that every requirement is necessary, unambiguous, complete, precise, consistent and testable, and finds ambiguous wording, misused or undefined technical terms, and semantic gaps. Handles long documents by delegating the term inventory, section reviews, cross-section checks, verification and report writing to subagents. Use when the user asks to review, check, proofread or assess an ETSI deliverable (ES, EN, TS, TR, EG, GS), a TTCN-3 standard clause, a draft in src/, a change request, or a Word file (.docx). For a .docx, spelling, grammar and editorial fixes are visible tracked changes by author "AI Reviewer" in dark green, and other findings are comments.
disable-model-invocation: true
---

@@ -37,7 +37,9 @@ Review progress:
```

**0. Size the text.** Count lines and list headings (`rg -n '^#{1,4} ' <file>`). For a PDF,
extract the text with `pdftotext -layout` and count pages.
extract the text with `pdftotext -layout` and count pages. For a `.docx`, extract plain text
(for example with `pandoc -t plain`) and follow "Word documents (.docx)" when writing the
review back. Run the mechanical scan on that extract, not on the raw package.

- Up to about 300 lines: review inline in one pass, findings kept in the conversation.
- Longer: delegate. Read [delegation.md](delegation.md) now and follow it. The parent
@@ -124,7 +126,8 @@ feasible. Review the changed text in the context of the clauses it affects.

**8. Report.** Use the template below. Quote the original text exactly, cite its location
(`file:line` for Markdown, page and clause for a PDF), and give concrete replacement text
wherever the intent is evident. Do not edit the document unless the user asks for it.
wherever the intent is evident. Do not edit the document unless the user asks for it. A
`.docx` is annotated in the file; see "Word documents (.docx)".

- The same problem in several places is one finding. List every location.
- Editorial findings go in a table (location, quote, proposal). If one pattern occurs more
@@ -134,6 +137,31 @@ wherever the intent is evident. Do not edit the document unless the user asks fo
  summary in the chat. For a long text the report is merged in two levels and assembled by
  `scripts/assemble.sh` (delegation.md, phase 6).

## Word documents (.docx)

When the file under review is a `.docx`, record the review in that file. Track changes stay
on for the whole edit, and every change stays visible.

- Enable track changes before the first edit (`w:trackRevisions` in `word/settings.xml`) and
  leave them on. The original wording remains in the revision markup.
- Author every revision and every comment as `AI Reviewer`. Use dark green for the revision
  colour where the markup allows a colour (`w:color w:val="006400"`).
- Spelling, grammar and editorial issues may be corrected in the text, as tracked insertions
  and deletions.
- Other issues, notes and discussions are Word comments by `AI Reviewer`, anchored to the
  passage they concern. Propose replacement wording in the comment when the intent is evident.

Write the revisions into the OOXML. A tool that replaces paragraph text, or a converter that
drops revisions, hides the edits. Each `w:ins` and `w:del` has `w:author="AI Reviewer"`, a
`w:date` and a unique `w:id`; deleted text is `w:delText`. Comments go in `word/comments.xml`,
anchored with `w:commentRangeStart`, `w:commentRangeEnd` and `w:commentReference`. Register
`comments.xml` in `[Content_Types].xml` and `word/_rels/document.xml.rels` when the part is
new.

The report in step 8 is still written. Editorial corrections already made as tracked changes
are listed briefly, or counted when they share one pattern. On a delegated review the
subagents leave the file untouched; the parent applies this section after the findings are in.

## Long texts

Consistency, terminology and gaps span sections, but no single context window holds a long
+2 −1
Changes for .agents/skills/reviewing-etsi-standards/delegation.md: 2 added lines, 1 removed line.
Original line number Diff line number Diff line
@@ -101,7 +101,8 @@ Scripts group concepts case-insensitively.
     `summary.md` and runs `scripts/assemble.sh`. No subagent reads all findings at once.
7. **Parent**: step 7 if the text is a revision or CR (delegate it like a section review if
   the affected clauses are long). Read the report Summary, check coverage, and give the
   user the summary and the report path.
   user the summary and the report path. When the source is a `.docx`, the parent then
   applies "Word documents (.docx)" in SKILL.md. Subagents leave that file untouched.

## Briefs