Commit 70417fef authored by Nikhil Doifode's avatar Nikhil Doifode
Browse files

Fixed Net Char Event displays values without selecting an element 

Changes:
- onUpdateElement was getting called separately for type and name, so the change in type was not happening because of timing delay.
So added separate code for updating it only once.
- Removed 8081 port for MEEP_HOST in package.json since it is not required now

Test:
- All UT's and Cypress test passed
- Manually checked, the old behaviour is not observed
parent 3929e690

js-apps/meep-frontend/package.json

+1 −1
Original line number Diff line number Diff line
@@ -8,7 +8,7 @@ 
    "test:verbose": "jest --verbose true",

    "test:coverage": "jest --verbose true --coverage --colors",

    "build": "webpack",

    "build:dev": "webpack-dev-server --https true --port 8092 --host 10.3.16.105 --env.MEEP_HOST=10.3.16.105:8081"

    "build:dev": "webpack-dev-server --https true --port 8092 --host 10.3.16.105 --env.MEEP_HOST=10.3.16.105"

  },

  "author": "",

  "license": "ISC",

js-apps/meep-frontend/src/js/containers/exec/network-characteristics-event-pane.js

+4 −2
Original line number Diff line number Diff line
@@ -159,8 +159,10 @@ class NetworkCharacteristicsEventPane extends Component { 


  onNetworkCharacPaneClose(e) {

    e.preventDefault();

    this.onUpdateElement(FIELD_TYPE, '', null);

    this.onUpdateElement(FIELD_NAME, '', null);

    var updatedElem = updateObject({}, this.props.element);

    setElemFieldVal(updatedElem, FIELD_NAME, '');

    setElemFieldVal(updatedElem, FIELD_TYPE, '');

    this.props.updateElement(updatedElem);

    this.props.onClose(e);

  }