From fe7427b9a02e50a1350a59a5fd47e62a55fde842 Mon Sep 17 00:00:00 2001
From: Lluis Gifre <lluis.gifre@cttc.es>
Date: Fri, 22 Oct 2021 23:29:00 +0200
Subject: [PATCH] Minor changes to remove code linting warnings
---
src/context/service/__main__.py | 4 ++--
src/context/service/grpc_server/ContextService.py | 12 ++++++------
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/context/service/__main__.py b/src/context/service/__main__.py
index 8a86b277b..979ee588d 100644
--- a/src/context/service/__main__.py
+++ b/src/context/service/__main__.py
@@ -16,12 +16,12 @@ from context.service.rest_server.resources.Context import Context
terminate = threading.Event()
logger = None
-def signal_handler(signal, frame):
+def signal_handler(signal_, frame):
logger.warning('Terminate signal received')
terminate.set()
def main():
- global logger
+ global logger # pylint: disable=global-statement
grpc_service_port = get_setting('CONTEXTSERVICE_SERVICE_PORT_GRPC', default=GRPC_SERVICE_PORT )
max_workers = get_setting('MAX_WORKERS', default=GRPC_MAX_WORKERS )
diff --git a/src/context/service/grpc_server/ContextService.py b/src/context/service/grpc_server/ContextService.py
index 1ea29f308..544dcad42 100644
--- a/src/context/service/grpc_server/ContextService.py
+++ b/src/context/service/grpc_server/ContextService.py
@@ -29,9 +29,9 @@ class ContextService:
self.server = None
def start(self):
- self.endpoint = '{}:{}'.format(self.address, self.port)
- LOGGER.debug('Starting Service (tentative endpoint: {}, max_workers: {})...'.format(
- self.endpoint, self.max_workers))
+ self.endpoint = '{:s}:{:s}'.format(self.address, self.port)
+ LOGGER.debug('Starting Service (tentative endpoint: {:s}, max_workers: {:s})...'.format(
+ str(self.endpoint), str(self.max_workers)))
self.pool = futures.ThreadPoolExecutor(max_workers=self.max_workers)
self.server = grpc.server(self.pool) # , interceptors=(tracer_interceptor,))
@@ -44,15 +44,15 @@ class ContextService:
add_HealthServicer_to_server(self.health_servicer, self.server)
port = self.server.add_insecure_port(self.endpoint)
- self.endpoint = '{}:{}'.format(self.address, port)
- LOGGER.info('Listening on {}...'.format(self.endpoint))
+ self.endpoint = '{:s}:{:s}'.format(str(self.address), str(port))
+ LOGGER.info('Listening on {:s}...'.format(str(self.endpoint)))
self.server.start()
self.health_servicer.set(OVERALL_HEALTH, HealthCheckResponse.SERVING) # pylint: disable=maybe-no-member
LOGGER.debug('Service started')
def stop(self):
- LOGGER.debug('Stopping service (grace period {} seconds)...'.format(self.grace_period))
+ LOGGER.debug('Stopping service (grace period {:s} seconds)...'.format(str(self.grace_period)))
self.health_servicer.enter_graceful_shutdown()
self.server.stop(self.grace_period)
LOGGER.debug('Service stopped')
--
GitLab