From eb22672fe7a99147a984102689ab5784a22c389c Mon Sep 17 00:00:00 2001
From: gifrerenom <lluis.gifre@cttc.es>
Date: Mon, 13 Nov 2023 17:46:08 +0000
Subject: [PATCH] Forecaster component:

- Updated TODO.txt
---
 src/forecaster/service/TODO.txt | 25 ++-----------------------
 1 file changed, 2 insertions(+), 23 deletions(-)

diff --git a/src/forecaster/service/TODO.txt b/src/forecaster/service/TODO.txt
index 9cc122219..e5fabe3fe 100644
--- a/src/forecaster/service/TODO.txt
+++ b/src/forecaster/service/TODO.txt
@@ -3,30 +3,9 @@ Use a smaller network:
 INFO     forecaster.tests.Tools:Tools.py:75 Discovering Devices and Links...
 INFO     forecaster.tests.Tools:Tools.py:104   Found 22 devices and 462 links...
 
-ERROR    grpc._server:_server.py:453 Exception calling application: The truth value of a Series is ambiguous. Use a.empty, a.bool(), a.item(), a.any() or a.all().
-Traceback (most recent call last):
-  File "/home/tfs/.pyenv/versions/3.9.13/envs/tfs/lib/python3.9/site-packages/grpc/_server.py", line 443, in _call_behavior
-    response_or_iterator = behavior(argument, context)
-  File "/home/tfs/tfs-ctrl/src/common/tests/MockServicerImpl_Monitoring.py", line 99, in QueryKpiData
-    df_samples = self.ts_db.filter(kpi_uuids, start_timestamp=start_timestamp, end_timestamp=end_timestamp)
-  File "/home/tfs/tfs-ctrl/src/common/tests/InMemoryTimeSeriesDatabase.py", line 30, in filter
-    if len(kpi_uuids) > 0: data = data[data.kpi_uuid in kpi_uuids]
-  File "/home/tfs/.pyenv/versions/3.9.13/envs/tfs/lib/python3.9/site-packages/pandas/core/generic.py", line 1527, in __nonzero__
-    raise ValueError(
-ValueError: The truth value of a Series is ambiguous. Use a.empty, a.bool(), a.item(), a.any() or a.all().
-
-
-Seems mock_context does not add device and link ids to the topology
-    def test_forecast_link(
-        context_client : ContextClient,
-        forecaster_client : ForecasterClient,
-    ):  # pylint: disable=redefined-outer-name
-        topology = context_client.GetTopology(ADMIN_TOPOLOGY_ID)
->       link_id = topology.link_ids[0]
-E       IndexError: list index (0) out of range
-
-
+In topology forecaster, the data file should contain more than 1 row per link, otherwise, it crashes with no enough samples.
 
+- implement integration with pathcomputation
 
 
 test case:
-- 
GitLab