From 17228dd56138c9bdd77c58cd772229315e12b7e0 Mon Sep 17 00:00:00 2001
From: gifrerenom <lluis.gifre@cttc.es>
Date: Mon, 10 Mar 2025 14:16:03 +0000
Subject: [PATCH] CI/CD pipeline code fixes

---
 src/kpi_manager/tests/test_kpi_manager.py | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/src/kpi_manager/tests/test_kpi_manager.py b/src/kpi_manager/tests/test_kpi_manager.py
index fedc3f94c..17a1c8d77 100755
--- a/src/kpi_manager/tests/test_kpi_manager.py
+++ b/src/kpi_manager/tests/test_kpi_manager.py
@@ -13,6 +13,7 @@
 # limitations under the License.
 
 
+import grpc
 import os, pytest
 import logging
 from typing import Union
@@ -109,13 +110,19 @@ def test_DeleteKpiDescriptor(kpi_manager_client):
     LOGGER.info(" >>> test_DeleteKpiDescriptor: START <<< ")
     # adding KPI
     response_id = kpi_manager_client.SetKpiDescriptor(create_kpi_descriptor_request())
+
     # deleting KPI
     del_response = kpi_manager_client.DeleteKpiDescriptor(response_id)
-    # select KPI
-    kpi_manager_client.GetKpiDescriptor(response_id)
     LOGGER.info("Response of delete method gRPC message object: {:}".format(del_response))
     assert isinstance(del_response, Empty)
 
+    # select KPI and check it does not exist
+    with pytest.raises(grpc.RpcError) as e:
+        kpi_manager_client.GetKpiDescriptor(response_id)
+    assert e.value.code() == grpc.StatusCode.NOT_FOUND
+    MSG = 'KpiDescriptor({:s}) not found'
+    assert e.value.details() == MSG.format(response_id.kpi_id.uuid)
+
 def test_GetKpiDescriptor(kpi_manager_client):
     LOGGER.info(" >>> test_GetKpiDescriptor: START <<< ")
     # adding KPI
@@ -123,11 +130,6 @@ def test_GetKpiDescriptor(kpi_manager_client):
     # get KPI
     response = kpi_manager_client.GetKpiDescriptor(response_id)
     LOGGER.info("Response gRPC message object: {:}".format(response))
-
-    LOGGER.info(" >>> calling GetKpiDescriptor with random ID")
-    rand_response = kpi_manager_client.GetKpiDescriptor(create_kpi_id_request())
-    LOGGER.info("Response gRPC message object: {:}".format(rand_response))
-
     assert isinstance(response, KpiDescriptor)
 
 def test_SelectKpiDescriptor(kpi_manager_client):
-- 
GitLab