From 14bd2c134d8330d06c7102decab0e695d0a3c728 Mon Sep 17 00:00:00 2001
From: Carlos Natalino <carlos.natalino@chalmers.se>
Date: Thu, 15 Feb 2024 11:18:18 +0000
Subject: [PATCH] Fixing the conditional that triggers response.
---
.../service/OpticalAttackDetectorServiceServicerImpl.py | 2 +-
src/opticalattackdetector/tests/test_unitary.py | 2 --
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/opticalattackdetector/service/OpticalAttackDetectorServiceServicerImpl.py b/src/opticalattackdetector/service/OpticalAttackDetectorServiceServicerImpl.py
index 11016037e..d8e8b649c 100644
--- a/src/opticalattackdetector/service/OpticalAttackDetectorServiceServicerImpl.py
+++ b/src/opticalattackdetector/service/OpticalAttackDetectorServiceServicerImpl.py
@@ -221,7 +221,7 @@ class OpticalAttackDetectorServiceServicerImpl(OpticalAttackDetectorServiceServi
monitoring_client.IncludeKpi(kpi)
# if -1 in response.cluster_indices: # attack detected
- if kpi.kpi_value.int32Val == -1:
+ if kpi.kpi_value.int32Val == 1:
attack = AttackDescription()
attack.cs_id.uuid = request.service_id.service_uuid.uuid
with HISTOGRAM_DURATION.labels(step="mitigation", **METRIC_LABELS).time():
diff --git a/src/opticalattackdetector/tests/test_unitary.py b/src/opticalattackdetector/tests/test_unitary.py
index 139e89890..3ed8be463 100644
--- a/src/opticalattackdetector/tests/test_unitary.py
+++ b/src/opticalattackdetector/tests/test_unitary.py
@@ -63,8 +63,6 @@ def test_detect_attack(
"opticalattackdetector.service.OpticalAttackDetectorServiceServicerImpl.monitoring_client.IncludeKpi",
) as monitoring, patch(
"opticalattackdetector.service.OpticalAttackDetectorServiceServicerImpl.dbscanserving_client.Detect",
- # TODO: return dumb object with "cluster_indices" attribute
- # idea: create new response object
return_value=message,
) as dbscanserving:
for _ in range(10):
--
GitLab