Commit 846fb248 authored by Adriana Fernández-Fernández's avatar Adriana Fernández-Fernández
Browse files

Refactors code for improved readability

parent 2ba780f1
Loading
Loading
Loading
Loading
+3 −1
Original line number Diff line number Diff line
@@ -548,7 +548,9 @@ class EdgeApplicationManager(EdgeCloudManagementInterface):
        """
        pass

    def get_deployed_app_gsma(self, app_id: str, app_instance_id: str, zone_id: str) -> Dict:
    def get_deployed_app_gsma(
        self, app_id: str, app_instance_id: str, zone_id: str
    ) -> Dict:
        """
        Retrieves an application instance details from partner OP.

+7 −5
Original line number Diff line number Diff line
@@ -522,9 +522,7 @@ class EdgeApplicationManager(EdgeCloudManagementInterface):
                appVersion=body.get("appVersion"),
                zoneInfo=schemas.ZoneInfo(flavourId=flavour_id, zoneId=zone_id),
            )
            payload = schemas.AppDeploy(
                app_deploy_data=app_deploy_data
            )
            payload = schemas.AppDeploy(app_deploy_data=app_deploy_data)
            url = "{}/application_instance".format(self.base_url)
            response = i2edge_post(url, payload)
            if response.status_code == 202:
@@ -545,7 +543,9 @@ class EdgeApplicationManager(EdgeCloudManagementInterface):
        except KeyError as e:
            raise I2EdgeError(f"Missing required field in GSMA deployment payload: {e}")

    def get_deployed_app_gsma(self, app_id: str, app_instance_id: str, zone_id: str) -> Dict:
    def get_deployed_app_gsma(
        self, app_id: str, app_instance_id: str, zone_id: str
    ) -> Dict:
        try:
            url = "{}/application_instance/{}/{}".format(
                self.base_url, zone_id, app_instance_id
@@ -605,7 +605,9 @@ class EdgeApplicationManager(EdgeCloudManagementInterface):
        except KeyError as e:
            raise I2EdgeError(f"Error retrieving apps: {e}")

    def undeploy_app_gsma(self, app_instance_id: str) -> Response:
    def undeploy_app_gsma(
        self, app_id: str, app_instance_id: str, zone_id: str
    ) -> Response:
        try:
            url = "{}/application_instance".format(self.base_url)
            response = i2edge_delete(url, app_instance_id)
+0 −1
Original line number Diff line number Diff line
@@ -12,7 +12,6 @@ from typing import Optional, Union
from uuid import UUID

from src.edgecloud import logger

from sunrise6g_opensdk.edgecloud.api.routers.lcm.schemas import RequiredResources
from sunrise6g_opensdk.edgecloud.core import utils as core_utils

+3 −1
Original line number Diff line number Diff line
@@ -380,7 +380,9 @@ class EdgeApplicationManager(EdgeCloudManagementInterface):
        """
        pass

    def get_deployed_app_gsma(self, app_id: str, app_instance_id: str, zone_id: str) -> Dict:
    def get_deployed_app_gsma(
        self, app_id: str, app_instance_id: str, zone_id: str
    ) -> Dict:
        """
        Retrieves an application instance details from partner OP.

+3 −1
Original line number Diff line number Diff line
@@ -248,7 +248,9 @@ class EdgeCloudManagementInterface(ABC):
        pass

    @abstractmethod
    def get_deployed_app_gsma(self, app_id: str, app_instance_id: str, zone_id: str) -> Dict:
    def get_deployed_app_gsma(
        self, app_id: str, app_instance_id: str, zone_id: str
    ) -> Dict:
        """
        Retrieves an application instance details from partner OP.