From cfa08d1da937bc93405b5630f897ba12de7ddca6 Mon Sep 17 00:00:00 2001
From: Jorge Moratinos Salcines <jorge.moratinossalcines@telefonica.com>
Date: Thu, 28 Nov 2024 16:32:12 +0100
Subject: [PATCH 1/2] fix supported-features key on query parameter

---
 .../Vendor Extensibility/vendor_extensibility.robot       | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/features/Vendor Extensibility/vendor_extensibility.robot b/tests/features/Vendor Extensibility/vendor_extensibility.robot
index b14dc71..c129470 100644
--- a/tests/features/Vendor Extensibility/vendor_extensibility.robot	
+++ b/tests/features/Vendor Extensibility/vendor_extensibility.robot	
@@ -44,7 +44,7 @@ Published API with vendor extensibility
 
     # Test
     ${resp}=    Get Request Capif
-    ...    ${DISCOVER_URL}${register_user_info_invoker['api_invoker_id']}&aef-id=${register_user_info['aef_id']}&supported_features=2
+    ...    ${DISCOVER_URL}${register_user_info_invoker['api_invoker_id']}&aef-id=${register_user_info['aef_id']}&supported-features=2
     ...    server=${CAPIF_HTTPS_URL}
     ...    verify=ca.crt
     ...    username=${INVOKER_USERNAME}
@@ -87,7 +87,7 @@ Published API with vendor extensibility and discover with VendSpecQueryParams di
 
     # Test
     ${resp}=    Get Request Capif
-    ...    ${DISCOVER_URL}${register_user_info_invoker['api_invoker_id']}&aef-id=${register_user_info['aef_id']}&supported_features=0
+    ...    ${DISCOVER_URL}${register_user_info_invoker['api_invoker_id']}&aef-id=${register_user_info['aef_id']}&supported-features=0
     ...    server=${CAPIF_HTTPS_URL}
     ...    verify=ca.crt
     ...    username=${INVOKER_USERNAME}
@@ -238,7 +238,7 @@ Published API without vendor extensibility discover with VendSpecQueryParams ena
 
     # Test
     ${resp}=    Get Request Capif
-    ...    ${DISCOVER_URL}${register_user_info_invoker['api_invoker_id']}&aef-id=${register_user_info['aef_id']}&supported_features=2
+    ...    ${DISCOVER_URL}${register_user_info_invoker['api_invoker_id']}&aef-id=${register_user_info['aef_id']}&supported-features=2
     ...    server=${CAPIF_HTTPS_URL}
     ...    verify=ca.crt
     ...    username=${INVOKER_USERNAME}
@@ -267,7 +267,7 @@ Published API without vendor extensibility and discover with vendSpecQueryParams
 
     # Test
     ${resp}=    Get Request Capif
-    ...    ${DISCOVER_URL}${register_user_info_invoker['api_invoker_id']}&aef-id=${register_user_info['aef_id']}&supported_features=0
+    ...    ${DISCOVER_URL}${register_user_info_invoker['api_invoker_id']}&aef-id=${register_user_info['aef_id']}&supported-features=0
     ...    server=${CAPIF_HTTPS_URL}
     ...    verify=ca.crt
     ...    username=${INVOKER_USERNAME}
-- 
GitLab


From c432783727648464bc4ccfc5d98891344dd9ccf4 Mon Sep 17 00:00:00 2001
From: Jorge Moratinos Salcines <jorge.moratinossalcines@telefonica.com>
Date: Thu, 28 Nov 2024 16:43:03 +0100
Subject: [PATCH 2/2] Minor changes to be aligned with code

---
 .../Vendor Extensibility/vendor_extensibility.robot  | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/tests/features/Vendor Extensibility/vendor_extensibility.robot b/tests/features/Vendor Extensibility/vendor_extensibility.robot
index c129470..d419262 100644
--- a/tests/features/Vendor Extensibility/vendor_extensibility.robot	
+++ b/tests/features/Vendor Extensibility/vendor_extensibility.robot	
@@ -184,8 +184,8 @@ Publish API with vendorExt active but without vendorSpecifics
     ...    ProblemDetails
     ...    title=Bad Request
     ...    status=400
-    ...    detail=VendorExt feature active at Supported Features but VendorSpecifics parameters not published
-    ...    cause=VendorExt feature active but vendorSpecifics not present
+    ...    detail=If and only if VendorExt feature is enabled, then vendor-specific fields should be defined
+    ...    cause=Vendor extensibility misconfiguration
 
 Publish API with vendorExt inactive but with vendorSpecifics
     [Tags]    vendor_extensibility-5
@@ -220,8 +220,8 @@ Publish API with vendorExt inactive but with vendorSpecifics
     ...    ProblemDetails
     ...    title=Bad Request
     ...    status=400
-    ...    detail=VendorExt feature inactive at Supported Features but VendorSpecifics are present parameters published
-    ...    cause=VendorExt feature inactive but vendorSpecifics present
+    ...    detail=If and only if VendorExt feature is enabled, then vendor-specific fields should be defined
+    ...    cause=Vendor extensibility misconfiguration
 
 Published API without vendor extensibility discover with VendSpecQueryParams enabled
     [Tags]    vendor_extensibility-6
@@ -331,5 +331,5 @@ Publish API without supportedFeatures
     ...    ProblemDetails
     ...    title=Bad Request
     ...    status=400
-    ...    detail=supportedFeatures must be present in this request
-    ...    cause=supportedFeatures missed
+    ...    detail=supportedFeatures not present in request
+    ...    cause=supportedFeatures not present
-- 
GitLab