Commit eaa3b27d authored by Daniel Honsel's avatar Daniel Honsel
Browse files

removed warnings

parent 230f3463

de.ugoe.cs.swe.TTCN3/src/de/ugoe/cs/swe/scoping/TTCN3GlobalScopeProvider.java

+0 −5
Original line number Diff line number Diff line
@@ -5,7 +5,6 @@ import java.util.List; 
import java.util.Map;

import java.util.Set;



import org.antlr.misc.MultiMap;

import org.eclipse.emf.ecore.EObject;

import org.eclipse.emf.ecore.EReference;

import org.eclipse.emf.ecore.resource.Resource;
@@ -23,13 +22,9 @@ import org.eclipse.xtext.scoping.impl.MultimapBasedSelectable; 
import org.eclipse.xtext.util.IResourceScopeCache;



import com.google.common.base.Predicate;

import com.google.common.collect.ArrayListMultimap;

import com.google.common.collect.HashMultimap;

import com.google.common.collect.ListMultimap;

import com.google.common.collect.Lists;

import com.google.common.collect.Maps;

import com.google.common.collect.Multimap;

import com.google.common.collect.Multimaps;

import com.google.common.collect.SetMultimap;

import com.google.common.collect.Sets;

import com.google.inject.Inject;

de.ugoe.cs.swe.TTCN3/src/de/ugoe/cs/swe/validation/CodeStyleValidator.xtend

+22 −22
Original line number Diff line number Diff line
@@ -116,7 +116,7 @@ class CodeStyleValidator extends AbstractDeclarativeValidator { 
			LabelStatement: message = "A \"label\" statement is used!"

		}



		TTCN3StatisticsProvider.getInstance.incrementCountStyle

		statistics.incrementCountStyle



		warning(

			message,
@@ -136,7 +136,7 @@ class CodeStyleValidator extends AbstractDeclarativeValidator { 
		val depth = alt.nestingDepth(AltConstruct)

		val INode node = NodeModelUtils.getNode(alt)

		if (depth > activeProfile.maximumAllowedNestingDepth) {

			TTCN3StatisticsProvider.getInstance.incrementCountStyle

			statistics.incrementCountStyle

			val message = "Alt statement nesting depth (" + depth + ") exceeds maximum allowed nesting depth (" +

				activeProfile.maximumAllowedNestingDepth + ")!"

			warning(
@@ -167,7 +167,7 @@ class CodeStyleValidator extends AbstractDeclarativeValidator { 
		if (!activeProfile.checkNoPermutationKeyword)

			return;



		TTCN3StatisticsProvider.getInstance.incrementCountStyle

		statistics.incrementCountStyle



		val INode node = NodeModelUtils.getNode(permutation)

		val message = "Keyword \"permutation\" is used!"
@@ -187,7 +187,7 @@ class CodeStyleValidator extends AbstractDeclarativeValidator { 
			return;



		if (type.pre != null && type.pre == 'anytype') {

			TTCN3StatisticsProvider.getInstance.incrementCountStyle

			statistics.incrementCountStyle

			val INode node = NodeModelUtils.getNode(type)

			val message = "Keyword \"anytype\" is used!"

			warning(
@@ -210,7 +210,7 @@ class CodeStyleValidator extends AbstractDeclarativeValidator { 
			val baseTemplate = template.derived.template.findDesiredParent(TemplateDef)

			val INode node = NodeModelUtils.getNode(template)

			if (baseTemplate.derived != null) {

				TTCN3StatisticsProvider.getInstance.incrementCountStyle

				statistics.incrementCountStyle

				val message = "Template \"" + template.base.name + "\" modifies another modified template (\"" +

					baseTemplate.base.name + "\")!"

				warning(
@@ -309,7 +309,7 @@ class CodeStyleValidator extends AbstractDeclarativeValidator { 
		for (c : foundChilds) {

			val message = "Local definition is not at the beginning!"

			val INode node = NodeModelUtils.getNode(c)

			TTCN3StatisticsProvider.getInstance.incrementCountStyle

			statistics.incrementCountStyle

			warning(

				message,

				null, //TODO: struct feature
@@ -327,7 +327,7 @@ class CodeStyleValidator extends AbstractDeclarativeValidator { 
		val INode node = NodeModelUtils.getNode(o)

		if (configuredOrder.contains(o.eClass)) {

			if (params.hasOtherDefinitions) {

				TTCN3StatisticsProvider.getInstance.incrementCountStyle

				statistics.incrementCountStyle

				val message = "Local definition is not at the beginning!"

				warning(

					message,
@@ -339,7 +339,7 @@ class CodeStyleValidator extends AbstractDeclarativeValidator { 
				);

			} else {

				if ((currentLocalDefinitionTypeOrderLevel < params.previousLocalDefinitionsOrderLevel)) {

					TTCN3StatisticsProvider.getInstance.incrementCountStyle

					statistics.incrementCountStyle

					val message = "Local definition order is not maintained as configured (" +

						configuredOrder.eClassesToString + ")!"

					warning(
@@ -402,7 +402,7 @@ class CodeStyleValidator extends AbstractDeclarativeValidator { 
		for (d : module.defs.definitions) {

			if (d.def instanceof ImportDef) {

				if (hasOtherDefs) {

					TTCN3StatisticsProvider.getInstance.incrementCountStyle

					statistics.incrementCountStyle

					val message = "Import statement is not at the beginning!"

					val INode node = NodeModelUtils.getNode(d)

					warning(
@@ -477,7 +477,7 @@ class CodeStyleValidator extends AbstractDeclarativeValidator { 
		}



		if (idExists) {

			TTCN3StatisticsProvider.getInstance.incrementCountStyle

			statistics.incrementCountStyle

			val message = "Identifier \"" + detailDef.name + "\" on the module level has already been used in " +

				parentModule.name + "!"

			val INode node = NodeModelUtils.getNode(detailDef)
@@ -599,7 +599,7 @@ class CodeStyleValidator extends AbstractDeclarativeValidator { 
		}



		if (notReferenced) {

			TTCN3StatisticsProvider.getInstance.incrementCountStyle

			statistics.incrementCountStyle

			val message = "Definition for \"" + detailDef.name + "\" is never referenced!"

			val INode node = NodeModelUtils.getNode(detailDef)

			warning(
@@ -661,7 +661,7 @@ class CodeStyleValidator extends AbstractDeclarativeValidator { 
		if (template.type == null)

			return;



		TTCN3StatisticsProvider.getInstance.incrementCountStyle

		statistics.incrementCountStyle



		val message = "Inline Template is used!"

		val INode node = NodeModelUtils.getNode(template)
@@ -711,7 +711,7 @@ class CodeStyleValidator extends AbstractDeclarativeValidator { 
			}



			if (overSpecified) {

				TTCN3StatisticsProvider.getInstance.incrementCountStyle

				statistics.incrementCountStyle

				warning(

					message,

					null, //TODO: EStructuralFeature
@@ -727,7 +727,7 @@ class CodeStyleValidator extends AbstractDeclarativeValidator { 


	private def boolean specifiedComponentResolved(TTCN3Reference parent, ComponentDef component) {

		if (Strings.isNullOrEmpty(component.name)) {

			TTCN3StatisticsProvider.getInstance.incrementCountStyle

			statistics.incrementCountStyle

			val message = "" + "Runs on component reference of \"" + parent.name +

				"\" cannot be resolved. It may not be possible to determine whether construct has an over-specific runs on clause!"

			val INode node = NodeModelUtils.getNode(parent)
@@ -751,7 +751,7 @@ class CodeStyleValidator extends AbstractDeclarativeValidator { 


		for (f : parent.getAllContentsOfType(FunctionInstance).map[it.ref]) {

			if (consideredAltOrFunc.contains(f)) {

				TTCN3StatisticsProvider.getInstance.incrementCountStyle

				statistics.incrementCountStyle

				val message = "" + "Possible cyclic call sequence: \"" + f.name + "\". Skipping..."

				val INode node = NodeModelUtils.getNode(f)

				info(
@@ -770,7 +770,7 @@ class CodeStyleValidator extends AbstractDeclarativeValidator { 


		for (a : parent.getAllContentsOfType(AltstepInstance).map[it.ref]) {

			if (consideredAltOrFunc.contains(a)) {

				TTCN3StatisticsProvider.getInstance.incrementCountStyle

				statistics.incrementCountStyle

				val message = "" + "Possible cyclic call sequence: \"" + a.name + "\". Skipping..."

				val INode node = NodeModelUtils.getNode(a)

				info(
@@ -916,7 +916,7 @@ class CodeStyleValidator extends AbstractDeclarativeValidator { 
			}

			if ((current.eContainer as TemplateDef).derived != null) {

				if (consideredTemplates.contains((current.eContainer as TemplateDef).derived.template)) {

					TTCN3StatisticsProvider.getInstance.incrementCountStyle

					statistics.incrementCountStyle

					val message = "" + "Possible cyclic modifies sequence: \"" + template.name + "\". Skipping..."

					val INode node = NodeModelUtils.getNode(template)

					info(
@@ -945,7 +945,7 @@ class CodeStyleValidator extends AbstractDeclarativeValidator { 
		val module = parent.findDesiredParent(TTCN3Module)

		for (p : params) {

			if (p.isUnreferenced(module)) { // TODO: test this call and consider alternatives and fix this! Parameters passed to other functions are not recognized.

				TTCN3StatisticsProvider.getInstance.incrementCountStyle

				statistics.incrementCountStyle

				val message = "Formal parameter \"" + (p as TTCN3Reference).name + "\" in definition for \"" +

					(parent as TTCN3Reference).name + "\" is never used!"

				val INode node = NodeModelUtils.getNode(p)
@@ -997,7 +997,7 @@ class CodeStyleValidator extends AbstractDeclarativeValidator { 
		if (variable.variableLocal) {

			val module = variable.findDesiredParent(TTCN3Module)

			if (variable.isUnreferenced(module)) {

				TTCN3StatisticsProvider.getInstance.incrementCountStyle

				statistics.incrementCountStyle

				val message = "Local definition for \"" + variable.name + "\" in definition of \"" + module.name +

					"\" is never used!"

				val INode node = NodeModelUtils.getNode(variable)
@@ -1037,7 +1037,7 @@ class CodeStyleValidator extends AbstractDeclarativeValidator { 
		if (parentModulePar == null && parentConstDef == null && parentTemplate == null) {

			if (value.bstring != null || value.integer != null || value.float != null || value.hstring != null ||

				value.ostring != null || value.charString != null) {

				TTCN3StatisticsProvider.getInstance.incrementCountStyle

				statistics.incrementCountStyle

				val message = "Literal value is used!"

				val INode node = NodeModelUtils.getNode(value)

				warning(
@@ -1065,7 +1065,7 @@ class CodeStyleValidator extends AbstractDeclarativeValidator { 
		

		for (d : data) {

			if (d.module == null) {

				TTCN3StatisticsProvider.getInstance.incrementCountStyle

				statistics.incrementCountStyle

				val message = "Imported module \"" + d.importDef.name + "\" cannot be resolved!"

				val INode node = NodeModelUtils.getNode(d.importDef)

				warning(
@@ -1082,7 +1082,7 @@ class CodeStyleValidator extends AbstractDeclarativeValidator { 
			var boolean found = module.isReferenced2(target)

			

			if (!found && d.module != null) {

				TTCN3StatisticsProvider.getInstance.incrementCountStyle

				statistics.incrementCountStyle

				val message = "No definitions from imported module \"" + d.importDef.name + "\" are ever used!"

				val INode node = NodeModelUtils.getNode(d.importDef)

				warning(