ETSI's Bug Tracker - Part 01: TTCN-3 Core Language
View Issue Details

ID | Project | Category | View Status | Date Submitted | Last Update
0007677 | Part 01: TTCN-3 Core Language | Technical | public | 05-06-2017 14:21 | 30-12-2017 21:08

Reporter | Tomas Urban |
Assigned To | Gyorgy Rethy |
Priority | normal | Severity | minor | Reproducibility | have not tried
Status | closed | Resolution | fixed |
Platform |  | OS |  | OS Version |
Product Version | v4.9.1 (published 2017-05) |
Target Version | v4.10.1 (published 2018-05) | Fixed in Version | v4.10.1 (published 2018-05) |
Clause Reference(s) | 21.1.2
Source (company - Author) | Elvior

Summary | 0007677: Additional restriction for the disconnect operation

Description

According to the current rules, if the disconnect operation is applied to a mapped port, it has no effect. However, it doesn't make much sense to allow the disconnect operation when one of the parameters is a system port as such operation will never do anything and the user most likely made a mistake. System port references are detectable during compilation as they are always in the format "system:portName".
For that reason, I propose to add the following restriction to the chapter 21.1.2:
The disconnect operation parameters shall not contain an explicit system port reference.

Steps To Reproduce |
Additional Information |
Tags | No tags attached.

Relationships

related to | 0007607 | closed | Gyorgy Rethy | Additional restriction for the connect operation

Attached Files | CR_7677.docx (162,654) 07-06-2017 11:30 http://oldforge.etsi.org/mantis/file_download.php?file_id=3603&type=bug CR_7677-v2.docx (187,145) 08-06-2017 16:32 http://oldforge.etsi.org/mantis/file_download.php?file_id=3612&type=bug CR_7677-v2_CR_7607.docx (164,539) 08-06-2017 20:40 http://oldforge.etsi.org/mantis/file_download.php?file_id=3613&type=bug

Issue History
Date Modified | Username | Field | Change
05-06-2017 14:21 | Tomas Urban | New Issue |
06-06-2017 09:32 | Jacob Wieland - Spirent | Note Added: 0014617 |
06-06-2017 10:06 | szabados | Note Added: 0014618 |
06-06-2017 11:09 | Jens Grabowski | Note Added: 0014619 |
06-06-2017 11:11 | Jens Grabowski | Assigned To | => KristÃ³f Szabados
06-06-2017 11:11 | Jens Grabowski | Status | new => assigned
07-06-2017 11:30 | KristÃ³f Szabados | File Added: CR_7677.docx |
07-06-2017 11:31 | KristÃ³f Szabados | Note Added: 0014646 |
07-06-2017 11:31 | KristÃ³f Szabados | Assigned To | KristÃ³f Szabados => Tomas Urban
07-06-2017 11:31 | KristÃ³f Szabados | Status | assigned => confirmed
08-06-2017 08:56 | Jacob Wieland - Spirent | Note Added: 0014650 |
08-06-2017 16:32 | Tomas Urban | File Added: CR_7677-v2.docx |
08-06-2017 16:32 | Tomas Urban | Assigned To | Tomas Urban => KristÃ³f Szabados
08-06-2017 16:32 | Tomas Urban | Status | confirmed => assigned
08-06-2017 16:35 | Tomas Urban | Note Added: 0014659 |
08-06-2017 16:35 | Tomas Urban | Status | assigned => confirmed
08-06-2017 20:34 | KristÃ³f Szabados | Relationship added | related to 0007607
08-06-2017 20:40 | KristÃ³f Szabados | File Added: CR_7677-v2_CR_7607.docx |
08-06-2017 20:41 | KristÃ³f Szabados | Note Added: 0014660 |
08-06-2017 20:42 | KristÃ³f Szabados | Assigned To | KristÃ³f Szabados => Tomas Urban
08-06-2017 20:42 | KristÃ³f Szabados | Status | confirmed => assigned
08-06-2017 20:42 | KristÃ³f Szabados | Note Added: 0014661 |
09-06-2017 08:13 | Tomas Urban | Note Added: 0014672 |
09-06-2017 08:13 | Tomas Urban | Status | assigned => resolved
09-06-2017 08:13 | Tomas Urban | Resolution | open => fixed
09-06-2017 08:13 | Tomas Urban | Assigned To | Tomas Urban => Gyorgy Rethy
30-12-2017 21:00 | Gyorgy Rethy | Note Added: 0014973 |
30-12-2017 21:00 | Gyorgy Rethy | Product Version | v4.10.1 (published 2018-05) => v4.9.1 (published 2017-05)
30-12-2017 21:00 | Gyorgy Rethy | Fixed in Version | => v4.10.1 (published 2018-05)
30-12-2017 21:00 | Gyorgy Rethy | Target Version | => v4.10.1 (published 2018-05)
30-12-2017 21:08 | Gyorgy Rethy | Status | resolved => closed

Notes

(0014617)
Jacob Wieland - Spirent
06-06-2017 09:32

that is only partly correct. Any component reference given as a parameter could be the system component, so any <component_ref>:<port_ref> could be a system port reference that is only detectable at runtime, if <component_ref> is a parameter or other component-type variable.

(0014618)
szabados
06-06-2017 10:06

The restriction could also be written to the connect operation. Although from the description of the operation it comes that system should not be used ... it is better to explicitly state this fr both connect and disconnect.

(0014619)
Jens Grabowski
06-06-2017 11:09

STF discussion: add restriction, check also for connect, map, unmap

(0014646)
KristÃ³f Szabados
07-06-2017 11:31

could you please review the changes?

(0014650)
Jacob Wieland - Spirent
08-06-2017 08:56

I would strike the word 'explicit'. connect is not allowed if either of the components is the system component. If a tool can determine that statically, it can decide to reject that at compile time, otherwise, it shall be rejected at runtime at the latest.

(0014659)
Tomas Urban
08-06-2017 16:35

I made some changes according to the Jacob's proposal. Error handling is done according to the restriction 21.1.1.e, i.e. in compile time if possible and in runtime otherwise. I added a similar restriction to the map operation which should always contain one component port and one system port. Please check.

(0014660)
KristÃ³f Szabados
08-06-2017 20:41

as the edited text overlaps with CR 7607 I "related" the 2 CRs together to solve them in 1 document.

(0014661)
KristÃ³f Szabados
08-06-2017 20:42

Please review

(0014672)
Tomas Urban
09-06-2017 08:13

Reviewed, no more issues found. The proposal resolves the CR and is ready to be included in the next version of the core language specification.

(0014973)
Gyorgy Rethy
30-12-2017 21:00

Implemented in draft V4.9.2