ETSI's Bug Tracker - Part 05: TTCN-3 Runtime Interface
View Issue Details

ID | Project | Category | View Status | Date Submitted | Last Update
0005947 | Part 05: TTCN-3 Runtime Interface | Technical | public | 15-10-2011 18:11 | 02-12-2011 12:55

Reporter | Mateusz Pusz |
Assigned To | Ina Schieferdecker |
Priority | normal | Severity | trivial | Reproducibility | N/A
Status | closed | Resolution | fixed |
Platform |  | OS |  | OS Version |
Product Version |  |
Target Version | v4.4.1 (published 2012-04) | Fixed in Version | v4.4.1 (published 2012-04) |
Clause Reference(s) | TRI 8.5.2.4
Source (company - Author) | Mateusz Pusz/freettcn

Summary | 0005947: Problem with C++ mapping of TriComponentId::getComponentName()
Description | TriComponentId::getComponentName() should return const reference to Tstring so it should look like: virtual const Tstring &getComponentName() const = 0; (see https://github.com/mpusz/FreeTTCN/blob/d2ff73bbb9f4bb5e49b5cabe2c156512e456056c/freettcn/lib/include/freettcn/etsi/tri.h#L69 [^]) Best Mat
Steps To Reproduce |
Additional Information |
Tags | No tags attached.
Relationships |
Attached Files |

Issue History
Date Modified | Username | Field | Change
15-10-2011 18:11 | Mateusz Pusz | New Issue |
15-10-2011 18:11 | Mateusz Pusz | Clause Reference(s) | => TRI 8.5.2.4
15-10-2011 18:11 | Mateusz Pusz | Source (company - Author) | => Mateusz Pusz/freettcn
28-11-2011 12:52 | Gyorgy Rethy | Project | TTCN-3 Change Requests => Part 05: TTCN-3 Runtime Interface
28-11-2011 16:15 | Gyorgy Rethy | Note Added: 0010359 |
28-11-2011 16:15 | Gyorgy Rethy | Assigned To | => Ina Schieferdecker
28-11-2011 16:15 | Gyorgy Rethy | Status | new => assigned
28-11-2011 16:15 | Gyorgy Rethy | Target Version | => Edition 4.4.1
01-12-2011 15:32 | Jacob Wieland - Spirent | Note Added: 0010487 |
02-12-2011 07:01 | Ina Schieferdecker | Note Added: 0010496 |
02-12-2011 07:02 | Ina Schieferdecker | Status | assigned => resolved
02-12-2011 07:02 | Ina Schieferdecker | Resolution | open => fixed
02-12-2011 07:02 | Ina Schieferdecker | Fixed in Version | => Edition 4.4.1
02-12-2011 07:02 | Ina Schieferdecker | Status | resolved => closed
02-12-2011 09:15 | Mateusz Pusz | Status | closed => feedback
02-12-2011 09:15 | Mateusz Pusz | Resolution | fixed => reopened
02-12-2011 09:15 | Mateusz Pusz | Note Added: 0010500 |
02-12-2011 11:03 | Ina Schieferdecker | Note Added: 0010510 |
02-12-2011 12:55 | Ina Schieferdecker | Status | feedback => closed
02-12-2011 12:55 | Ina Schieferdecker | Resolution | reopened => fixed

Notes

(0010359)
Gyorgy Rethy
28-11-2011 16:15

STF discussion 28/11: Check if there is an error in the standard. If not, postpone the CR to 2012.

(0010487)
Jacob Wieland - Spirent
01-12-2011 15:32

that is correct. Please implement as proposed.

(0010496)
Ina Schieferdecker
02-12-2011 07:01

Changed all getter methods to const:
class TriAddress {
public:
...
virtual const Tsize getBitsDataLen()const=0;
...
class TriComponentId {
public:
...
virtual const Tstring & getComponentName () const =0;
...
class TriException {
public:
...
virtual const Tsize getBitsDataLen()const=0;
...
class TriMessage {
public:
...
virtual const Tsize getBitsDataLen()const=0;
...
class TriParameter {
public:
...
virtual const Tsize getBitsDataLen()const=0;
...
class TriPortId {
public:
...
virtual const Tsize getPortIndex () const =0;
...
class TriTimerDuration {
public:
...
virtual const Tfloat getDuration () const =0;
...

(0010500)
Mateusz Pusz
02-12-2011 09:15

Please do not add any other consts that requested. They are not needed there. The values are passed there by copy and not a reference or pointer. Adding const to a passing by value only obfuscates the code and does not solve any problem.

(0010510)
Ina Schieferdecker
02-12-2011 11:03

well, this sounds inconsistent to the STF - but we buy your C++ expertise and will add const to getComponentName() only