Commit fba863e0 authored by Simon Pastor's avatar Simon Pastor
Browse files

code review comments

parent 6922b6d6

go-apps/meep-ctrl-engine/server/logger.go

+6 −6
Original line number Diff line number Diff line
@@ -25,9 +25,10 @@ 
package server



import (

	"log"

	"net/http"

	"time"



	log "github.com/InterDigitalInc/AdvantEDGE/go-packages/meep-logger"

)



func Logger(inner http.Handler, name string) http.Handler {
@@ -36,11 +37,10 @@ func Logger(inner http.Handler, name string) http.Handler { 


		inner.ServeHTTP(w, r)



		log.Printf(

			"%s %s %s %s",

			r.Method,

			r.RequestURI,

			name,

		log.Debug(

			r.Method, " ",

			r.RequestURI, " ",

			name, " ",

			time.Since(start),

		)

	})

go-apps/meep-ctrl-engine/server/routers.go

+1 −3
Original line number Diff line number Diff line
@@ -29,8 +29,6 @@ import ( 
	"net/http"

	"strings"



	log "github.com/InterDigitalInc/AdvantEDGE/go-packages/meep-logger"



	"github.com/gorilla/mux"

)
@@ -46,7 +44,7 @@ type Routes []Route 
func NewRouter() *mux.Router {

	router := mux.NewRouter().StrictSlash(true)

	for _, route := range routes {

		var handler http.Handler = log.HTTP(route.HandlerFunc, route.Name)

		var handler http.Handler = Logger(route.HandlerFunc, route.Name)



		router.

			Methods(route.Method).

go-apps/meep-loc-serv/server/logger.go

+6 −6
Original line number Diff line number Diff line
@@ -25,9 +25,10 @@ 
package server



import (

	"log"

	"net/http"

	"time"



	log "github.com/InterDigitalInc/AdvantEDGE/go-packages/meep-logger"

)



func Logger(inner http.Handler, name string) http.Handler {
@@ -36,11 +37,10 @@ func Logger(inner http.Handler, name string) http.Handler { 


		inner.ServeHTTP(w, r)



		log.Printf(

			"%s %s %s %s",

			r.Method,

			r.RequestURI,

			name,

		log.Debug(

			r.Method, " ",

			r.RequestURI, " ",

			name, " ",

			time.Since(start),

		)

	})

go-apps/meep-metrics-engine/server/logger.go

+6 −6
Original line number Diff line number Diff line
@@ -25,9 +25,10 @@ 
package server



import (

	"log"

	"net/http"

	"time"



	log "github.com/InterDigitalInc/AdvantEDGE/go-packages/meep-logger"

)



func Logger(inner http.Handler, name string) http.Handler {
@@ -36,11 +37,10 @@ func Logger(inner http.Handler, name string) http.Handler { 


		inner.ServeHTTP(w, r)



		log.Printf(

			"%s %s %s %s",

			r.Method,

			r.RequestURI,

			name,

		log.Debug(

			r.Method, " ",

			r.RequestURI, " ",

			name, " ",

			time.Since(start),

		)

	})

go-apps/meep-mg-manager/server/logger.go

+6 −6
Original line number Diff line number Diff line
@@ -25,9 +25,10 @@ 
package server



import (

	"log"

	"net/http"

	"time"



	log "github.com/InterDigitalInc/AdvantEDGE/go-packages/meep-logger"

)



func Logger(inner http.Handler, name string) http.Handler {
@@ -36,11 +37,10 @@ func Logger(inner http.Handler, name string) http.Handler { 


		inner.ServeHTTP(w, r)



		log.Printf(

			"%s %s %s %s",

			r.Method,

			r.RequestURI,

			name,

		log.Debug(

			r.Method, " ",

			r.RequestURI, " ",

			name, " ",

			time.Since(start),

		)

	})