Unverified Commit b1f814d6 authored by Kevin Di Lallo's avatar Kevin Di Lallo Committed by GitHub
Browse files

Merge pull request #264 from pastorsx/sp_dev_rnis_mandatory_param 

RNIS: Mandatory parameters for subscription enforced
parents c5a9bb30 4bd1f1ab

go-apps/meep-rnis/server/rnis.go

+18 −0
Original line number Diff line number Diff line
@@ -1982,6 +1982,12 @@ func subscriptionsPost(w http.ResponseWriter, r *http.Request) { 
			return

		}



		if subscription.FilterCriteriaQci.Qci == 0 {

			log.Error("Missing or non valid value for mandatory Qci parameter in FilterCriteriaQci")

			http.Error(w, "Missing or non valid value for mandatory Qci parameter in FilterCriteriaQci", http.StatusBadRequest)

			return

		}



		for _, ecgi := range subscription.FilterCriteriaQci.Ecgi {

			if ecgi.Plmn == nil || ecgi.CellId == "" {

				log.Error("For non null ecgi, plmn and cellId are mandatory")
@@ -2013,6 +2019,18 @@ func subscriptionsPost(w http.ResponseWriter, r *http.Request) { 
			return

		}



		if subscription.FilterCriteriaQci.Qci == 0 {

			log.Error("Missing or non valid value for mandatory Qci parameter in FilterCriteriaQci")

			http.Error(w, "Missing or non valid value for mandatory Qci parameter in FilterCriteriaQci", http.StatusBadRequest)

			return

		}



		if subscription.FilterCriteriaQci.ErabId == 0 {

			log.Error("Missing or non valid value of 0 mandatory ErabId parameter in FilterCriteriaQci")

			http.Error(w, "Missing or non valid value of 0 for mandatory ErabId parameter in FilterCriteriaQci", http.StatusBadRequest)

			return

		}



		for _, ecgi := range subscription.FilterCriteriaQci.Ecgi {

			if ecgi.Plmn == nil || ecgi.CellId == "" {

				log.Error("For non null ecgi, plmn and cellId are mandatory")