Commit 0a11cfce authored by Kevin Di Lallo's avatar Kevin Di Lallo
Browse files

code review updates

parent a173c586

go-packages/meep-subscriptions/subscription-mgr.go

+1 −1
Original line number Diff line number Diff line
@@ -265,7 +265,7 @@ func (sm *SubscriptionMgr) GetSubscriptionList(AppId string, Type string) ([]*Su 
func (sm *SubscriptionMgr) GenerateSubscriptionId() string {

	randomStr, _ := generateRand(12)

	// return uuid.New().String()

	return randomStr

	return "sub-" + randomStr

}



func (sm *SubscriptionMgr) ReadyToSend(sub *Subscription) bool {

go-packages/meep-subscriptions/websocket.go

+2 −2
Original line number Diff line number Diff line
@@ -64,9 +64,9 @@ func newWebsocket(cfg *WebsocketCfg) (*Websocket, error) { 
		log.Error(err.Error())

		return nil, err

	}

	ws.Id = randomStr

	ws.Id = "websocket-" + randomStr

	ws.State = WsStateInit

	ws.Endpoint = "ws/" + randomStr

	ws.Endpoint = "ws/" + ws.Id



	// Create websocket handler

	ws.ConnectionHandler = ws.connectionHandler