From b519f5ab140ed22d605caed635bd760598ecde48 Mon Sep 17 00:00:00 2001
From: Sylvain Renault <sylvain.renault@hhi.fraunhofer.de>
Date: Wed, 25 Sep 2024 17:31:55 +0200
Subject: [PATCH] Changed some response to Success/Error

---
 openapi                                                   | 2 +-
 .../ETSI-ARF/ControllersImpl/CapabilitiesImpl.cs          | 2 --
 .../ETSI-ARF/ControllersImpl/PoseImpl.cs                  | 8 ++++----
 3 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/openapi b/openapi
index 073fd72..7e50e43 160000
--- a/openapi
+++ b/openapi
@@ -1 +1 @@
-Subproject commit 073fd7213fd9e6ebc2f8a47d628a650de30c8bc4
+Subproject commit 7e50e43e90a8dcd958944e8e9ceda05c7668db48
diff --git a/server/worldanalysis/src/ETSI.ARF.OpenAPI.WorldAnalysis/ETSI-ARF/ControllersImpl/CapabilitiesImpl.cs b/server/worldanalysis/src/ETSI.ARF.OpenAPI.WorldAnalysis/ETSI-ARF/ControllersImpl/CapabilitiesImpl.cs
index 4638d5c..40252ed 100644
--- a/server/worldanalysis/src/ETSI.ARF.OpenAPI.WorldAnalysis/ETSI-ARF/ControllersImpl/CapabilitiesImpl.cs
+++ b/server/worldanalysis/src/ETSI.ARF.OpenAPI.WorldAnalysis/ETSI-ARF/ControllersImpl/CapabilitiesImpl.cs
@@ -68,7 +68,6 @@ namespace ETSI.ARF.OpenAPI.WorldAnalysis.Controllers
             GetCapabilities200Response response = new GetCapabilities200Response();
             response.Capabilities = capabilitiesList;
             return new ObjectResult(response);
-            //return StatusCode(405, "Not supported yet!");
         }
 
         /// <summary>
@@ -88,7 +87,6 @@ namespace ETSI.ARF.OpenAPI.WorldAnalysis.Controllers
             GetSupport200Response response = new GetSupport200Response();
             response.Capabilities = capabilitiesList;
             return new ObjectResult(response); 
-            //return StatusCode(405, "Not supported yet!");
         }
     }
 }
diff --git a/server/worldanalysis/src/ETSI.ARF.OpenAPI.WorldAnalysis/ETSI-ARF/ControllersImpl/PoseImpl.cs b/server/worldanalysis/src/ETSI.ARF.OpenAPI.WorldAnalysis/ETSI-ARF/ControllersImpl/PoseImpl.cs
index 4460641..b79c5b6 100644
--- a/server/worldanalysis/src/ETSI.ARF.OpenAPI.WorldAnalysis/ETSI-ARF/ControllersImpl/PoseImpl.cs
+++ b/server/worldanalysis/src/ETSI.ARF.OpenAPI.WorldAnalysis/ETSI-ARF/ControllersImpl/PoseImpl.cs
@@ -59,7 +59,7 @@ namespace ETSI.ARF.OpenAPI.WorldAnalysis.Controllers
 
             // Notify the modules that the client need a new framerate
             bool result = WorldAnalysisConnections.Singleton.ConfigureFramerate(poseConfiguration);
-            return result ? StatusCode(200, "Ok.") : StatusCode(405, "Not supported.");
+            return result ? StatusCode(200, new Success() { Message = "Ok." }) : StatusCode(405, new Error() { Message = "Not supported." });
         }
 
         /// <summary>
@@ -142,7 +142,7 @@ namespace ETSI.ARF.OpenAPI.WorldAnalysis.Controllers
                     return new ObjectResult(response);
                 }
             }
-            return StatusCode(404, "Not found.");
+            return StatusCode(404, new Error() { Message = "Not found." });
         }
 
         /// <summary>
@@ -206,7 +206,7 @@ namespace ETSI.ARF.OpenAPI.WorldAnalysis.Controllers
             info.subscription.WebhookUrl = response.WebhookUrl;
 
             m_subscriptionsPoses.Add(info.uuidSub, info);
-            
+
             // todo: inform the module(s) that the client will track an anchor/trackable and need the pose
             // todo: has the module to call GetRelocalizationInformation() then?!?
             WorldAnalysisConnections.Singleton.SubscribeToPose(info, parentUUID);
@@ -247,7 +247,7 @@ namespace ETSI.ARF.OpenAPI.WorldAnalysis.Controllers
 
             // todo: inform the module(s) that the subscription changed
 
-            return StatusCode(405, "Not supported yet!");
+            return StatusCode(405, new Error() { Message = "Not supported yet!" });
         }
     }
 }
-- 
GitLab